Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-15 18:14:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect auditing of geolocation MicroMVD in BIMTester

Browse Source
This commit is contained in:
Dion Moult
2020-09-09 14:21:10 +10:00
parent c58db675e3
commit ca6adffc25
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcbimtester/features/steps/geolocation.py
+4 -2
View File
@@ -3,6 +3,7 @@ from utils import IfcFile, assert_number, assert_pset, assert_attribute
import math import math
import ifcopenshell.util import ifcopenshell.util
import ifcopenshell.util.element import ifcopenshell.util.element
import ifcopenshell.util.geolocation
@step(u'There must be at least one {ifc_class} element') @step(u'There must be at least one {ifc_class} element')
def step_impl(context, ifc_class): def step_impl(context, ifc_class):
@@ -161,8 +162,7 @@ def step_impl(context, number):
return check_ifc2x3_geolocation('EPset_MapConversion', 'Height', number) return check_ifc2x3_geolocation('EPset_MapConversion', 'Height', number)
abscissa = check_ifc4_geolocation('IfcMapConversion', 'XAxisAbscissa', should_assert=False) abscissa = check_ifc4_geolocation('IfcMapConversion', 'XAxisAbscissa', should_assert=False)
ordinate = check_ifc4_geolocation('IfcMapConversion', 'XAxisOrdinate', should_assert=False) ordinate = check_ifc4_geolocation('IfcMapConversion', 'XAxisOrdinate', should_assert=False)
# TODO: migrate to geolocation util actual_value = round(ifcopenshell.util.geolocation.xy2angle(abscissa, ordinate) * -1, 3)
actual_value = round(math.degrees(math.atan2(ordinate, abscissa)) - 90, 3)
value = round(number, 3) value = round(number, 3)
assert actual_value == value, 'We expected a value of "{}" but instead got "{}"'.format(value, actual_value) assert actual_value == value, 'We expected a value of "{}" but instead got "{}"'.format(value, actual_value)
@@ -183,6 +183,7 @@ def step_impl(context, guid, number):
site = IfcFile.by_guid(guid) site = IfcFile.by_guid(guid)
if not site.is_a('IfcSite'): if not site.is_a('IfcSite'):
assert False, 'The element {} is not an IfcSite'.format(site) assert False, 'The element {} is not an IfcSite'.format(site)
number = ifcopenshell.util.geolocation.dd2dms(number)
assert_attribute(site, 'RefLongitude', number) assert_attribute(site, 'RefLongitude', number)
@@ -192,6 +193,7 @@ def step_impl(context, guid, number):
site = IfcFile.by_guid(guid) site = IfcFile.by_guid(guid)
if not site.is_a('IfcSite'): if not site.is_a('IfcSite'):
assert False, 'The element {} is not an IfcSite'.format(site) assert False, 'The element {} is not an IfcSite'.format(site)
number = ifcopenshell.util.geolocation.dd2dms(number)
assert_attribute(site, 'RefLatitude', number) assert_attribute(site, 'RefLatitude', number)