From cc0760d50566f326d07c3cb78ddead7d770ac46b Mon Sep 17 00:00:00 2001
From: Thomas Krijnen <t.krijnen@gmail.com>
Date: Sun, 21 Jul 2024 11:55:18 +0200
Subject: [PATCH] profile_helper() returns loop, not face, take into account in
 hollow profile def

---
 src/ifcgeom/mapping/IfcRectangleHollowProfileDef.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/ifcgeom/mapping/IfcRectangleHollowProfileDef.cpp b/src/ifcgeom/mapping/IfcRectangleHollowProfileDef.cpp
index c4b18e398a..6b5b77c9ba 100644
--- a/src/ifcgeom/mapping/IfcRectangleHollowProfileDef.cpp
+++ b/src/ifcgeom/mapping/IfcRectangleHollowProfileDef.cpp
@@ -68,11 +68,9 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcRectangleHollowProfileDef* i
 		return nullptr;
 	}
 
-	s1->children.push_back(s2->children[0]);
+	auto f = taxonomy::cast<taxonomy::face>(s1);
+	s2->external = false;
+	f->children.push_back(s2);
 
-#ifdef TAXONOMY_USE_NAKED_PTR
-	delete s2;
-#endif
-
-	return s1;
+	return f;
 }