Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-12 14:33:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where openings were not unlinked or renamed if they were removed from a non-dynamic object

Browse Source
This commit is contained in:
Dion Moult
2021-09-09 13:45:49 +10:00
parent 33bc0be5ff
commit ce92aa6e00
3 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blenderbim/test/bim/module/void/test_operator.py
+4 -3
View File
@@ -40,7 +40,7 @@ class TestAddOpening(test.bim.bootstrap.NewFile):
class TestRemoveOpening(test.bim.bootstrap.NewFile):
@test.bim.bootstrap.scenario
def test_removing_an_opening(self):
def test_removing_an_opening_manually(self):
return """
Given an empty IFC project
When the object "Cube" is selected
@@ -53,10 +53,11 @@ class TestRemoveOpening(test.bim.bootstrap.NewFile):
And I press "bim.remove_opening(opening_id=97, obj='IfcWall/Cube')"
Then the object "IfcWall/Cube" has no boolean difference by "IfcOpeningElement/Cube"
And the object "IfcWall/Cube" is not voided by "Cube"
And the object "Cube" is not an IFC element
"""
@test.bim.bootstrap.scenario
def test_removing_a_non_dynamic_opening(self):
def test_removing_a_non_dynamic_opening_manually(self):
return """
Given an empty IFC project
When the object "Cube" is selected
@@ -67,10 +68,10 @@ class TestRemoveOpening(test.bim.bootstrap.NewFile):
And additionally the object "Cube" is selected
And I press "bim.add_opening(opening='Cube', obj='IfcWall/Cube')"
And the object "IfcWall/Cube" is selected
And I press "bim.print_ifc_file"
And I press "bim.switch_representation(ifc_definition_id=86, should_reload=True)"
Then the object "IfcWall/Cube" has no boolean difference by "IfcOpeningElement/Cube"
And the object "IfcWall/Cube" has "16" vertices
When I press "bim.remove_opening(opening_id=97, obj='IfcWall/Cube')"
Then the object "IfcWall/Cube" has "8" vertices
And the object "Cube" is not an IFC element
"""