From cfd5742b5b45886863dd3c4e92c2147b6ebd5691 Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Sun, 6 Jun 2021 20:54:40 +1000 Subject: [PATCH] Fix unnecessary error message when getting psets. --- .../ifcopenshell/util/element.py | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/ifcopenshell-python/ifcopenshell/util/element.py b/src/ifcopenshell-python/ifcopenshell/util/element.py index 0bbcb8cb8f..c1218c9e5b 100644 --- a/src/ifcopenshell-python/ifcopenshell/util/element.py +++ b/src/ifcopenshell-python/ifcopenshell/util/element.py @@ -3,21 +3,15 @@ import ifcopenshell def get_psets(element): psets = {} - try: - if element.is_a("IfcTypeObject"): - if element.HasPropertySets: - for definition in element.HasPropertySets: - psets[definition.Name] = get_property_definition(definition) - else: - for relationship in element.IsDefinedBy: - if relationship.is_a("IfcRelDefinesByProperties"): - definition = relationship.RelatingPropertyDefinition - psets[definition.Name] = get_property_definition(definition) - except Exception as e: - import traceback - - print("failed to load properties: {}".format(e)) - traceback.print_exc() + if element.is_a("IfcTypeObject"): + if element.HasPropertySets: + for definition in element.HasPropertySets: + psets[definition.Name] = get_property_definition(definition) + elif hasattr(element, "IsDefinedBy"): + for relationship in element.IsDefinedBy: + if relationship.is_a("IfcRelDefinesByProperties"): + definition = relationship.RelatingPropertyDefinition + psets[definition.Name] = get_property_definition(definition) return psets