create_shape - raise the same error for representations and rep items

To be consistent with how it's handled when product+representation is passed, previously it would fail silently.
This commit is contained in:
Andrej730
2024-06-28 17:23:42 +05:00
parent dcc568f5a3
commit d1be0e8c1c
2 changed files with 9 additions and 2 deletions
+3 -1
View File
@@ -389,7 +389,9 @@ IfcGeom::ConversionResults ifcopenshell::geometry::Converter::convert(IfcUtil::I
IfcGeom::ConversionResults results;
if (geom_item) {
std::clock_t geom_start = std::clock();
kernel_->convert(geom_item, results);
if (!kernel_->convert(geom_item, results)) {
throw std::runtime_error("Failed to convert item");
}
std::clock_t geom_end = std::clock();
total_map_time += (geom_start - map_start) / (double) CLOCKS_PER_SEC;
total_geom_time += (geom_end - geom_start) / (double) CLOCKS_PER_SEC;