Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-26 18:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check walls first for false origin guessing for speed, checking one object seems to be enough

Browse Source
This commit is contained in:
Dion Moult
2024-09-24 15:31:37 +10:00
parent f92a02cfcb
commit d1c4a0a415
1 changed files with 9 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/bonsai/tool/loader.py
+9 -19
View File
@@ -782,43 +782,33 @@ class Loader(bonsai.core.tool.Loader):
@classmethod @classmethod
def get_offset_point(cls, ifc_file: ifcopenshell.file) -> Union[npt.NDArray[np.float64], None]: def get_offset_point(cls, ifc_file: ifcopenshell.file) -> Union[npt.NDArray[np.float64], None]:
elements_checked = 0 # Check walls first, as they're usually cheap
# If more than these elements aren't far away, the file probably isn't elements = ifc_file.by_type("IfcWall")
# absolutely positioned. We check more than 1 because sometimes users elements += ifc_file.by_type("IfcElement")
# try to be clever and put "origin marker" objects.
element_checking_threshold = 3
elements = ifc_file.by_type("IfcElement")
if ifc_file.schema not in ("IFC2X3", "IFC4"): if ifc_file.schema not in ("IFC2X3", "IFC4"):
if not elements: elements += ifc_file.by_type("IfcLinearPositioningElement")
elements = ifc_file.by_type("IfcLinearPositioningElement") elements += ifc_file.by_type("IfcReferent")
if not elements: elements += ifc_file.by_type("IfcGrid")
elements = ifc_file.by_type("IfcReferent")
if not elements:
elements = ifc_file.by_type("IfcGrid")
if ifc_file.schema == "IFC2X3": if ifc_file.schema == "IFC2X3":
if not elements: elements += ifc_file.by_type("IfcSpatialStructureElement")
elements = ifc_file.by_type("IfcSpatialStructureElement")
else: else:
if not elements: elements += ifc_file.by_type("IfcSpatialElement")
elements = ifc_file.by_type("IfcSpatialElement")
for element in elements: for element in elements:
if elements_checked > element_checking_threshold:
return
if not element.Representation: if not element.Representation:
continue continue
shape = cls.create_generic_shape(element, is_gross=True) shape = cls.create_generic_shape(element, is_gross=True)
if not shape: if not shape:
continue continue
elements_checked += 1
mat = ifcopenshell.util.shape.get_shape_matrix(shape) mat = ifcopenshell.util.shape.get_shape_matrix(shape)
point = mat @ np.array((shape.geometry.verts[0], shape.geometry.verts[1], shape.geometry.verts[2], 1.0)) point = mat @ np.array((shape.geometry.verts[0], shape.geometry.verts[1], shape.geometry.verts[2], 1.0))
if cls.is_point_far_away(point, is_meters=True): if cls.is_point_far_away(point, is_meters=True):
# Arbitrary origins should be to the nearest millimeter. # Arbitrary origins should be to the nearest millimeter.
# Anything more precise is just ridiculous from a practical surveying perspective. # Anything more precise is just ridiculous from a practical surveying perspective.
return [round(float(p), 3) / cls.unit_scale for p in point[:3]] return [round(float(p), 3) / cls.unit_scale for p in point[:3]]
break
@classmethod @classmethod
def guess_false_origin_from_elements(cls, ifc_file: ifcopenshell.file) -> None: def guess_false_origin_from_elements(cls, ifc_file: ifcopenshell.file) -> None: