From d472814e2a664781650b03d0d1d9a6085bcd72b9 Mon Sep 17 00:00:00 2001
From: Thomas Krijnen <t.krijnen@gmail.com>
Date: Thu, 30 Jul 2026 03:16:39 +0200
Subject: [PATCH] Don't try and set empty aggregates (todo: see if they are
 still needed with the type-aware upgrade-based parse mode)

---
 src/ifcparse/parse.cpp      | 2 ++
 src/ifcparse/spf_header.cpp | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/src/ifcparse/parse.cpp b/src/ifcparse/parse.cpp
index c36239efef..9a02b7a4a4 100644
--- a/src/ifcparse/parse.cpp
+++ b/src/ifcparse/parse.cpp
@@ -2616,6 +2616,8 @@ express::Base file::add_entity(const express::Base& entity, int id) {
             if constexpr (std::is_same_v<U, express::Base>) {
             } else if constexpr (std::is_same_v<U, std::vector<express::Base>>) {
             } else if constexpr (std::is_same_v<U, std::vector<std::vector<express::Base>>>) {
+            } else if constexpr (std::is_same_v<U, empty_aggregate_t>) {
+            } else if constexpr (std::is_same_v<U, empty_aggregate_of_aggregate_t>) {
             } else {
                 new_entity.set_attribute_value(i, v);
             }
diff --git a/src/ifcparse/spf_header.cpp b/src/ifcparse/spf_header.cpp
index 696c9162cd..75517f0c1d 100644
--- a/src/ifcparse/spf_header.cpp
+++ b/src/ifcparse/spf_header.cpp
@@ -108,6 +108,8 @@ void ifcopenshell::spf_header::assign(const spf_header& other) {
                     if constexpr (std::is_same_v<U, express::Base>) {
                     } else if constexpr (std::is_same_v<U, std::vector<express::Base>>) {
                     } else if constexpr (std::is_same_v<U, std::vector<std::vector<express::Base>>>) {
+                    } else if constexpr (std::is_same_v<U, empty_aggregate_t>) {
+                    } else if constexpr (std::is_same_v<U, empty_aggregate_of_aggregate_t>) {
                     } else {
                         new_entity.set_attribute_value(i, v);
                     }