Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-09 17:31:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Selector: add rotation_x/y/z value keys #6262

Browse Source 
Expose the Euler rotation of an element's placement in degrees through
get_element_value, alongside the existing x/y/z and easting/northing/
elevation keys. This makes element rotation exportable through ifccsv,
e.g. for placing oriented symbols in GIS.

Adopts the approach agreed in the review of the stale PR #6272 by
@TZwielehner: reuse util.shape_builder.np_matrix_to_euler and do the
degree conversion inside get_element_value.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Petru Conduraru
2026-07-05 20:25:05 +03:00
committed by Dion Moult
parent 69a4be68e8
commit d4805387ef
3 changed files with 29 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/test/util/test_selector.py
+16
View File
@@ -125,6 +125,22 @@ class TestGetElementValue(test.bootstrap.IFC4):
element.Name = "Foobar"
assert subject.get_element_value(element, "Name") == "Foobar"
def test_selecting_an_elements_rotation_using_a_query(self):
# Feature test for #6262: rotation_x/y/z value keys expose the
# placement's Euler angles in degrees, e.g. for GIS symbol placement.
ifcopenshell.api.root.create_entity(self.file, ifc_class="IfcProject")
ifcopenshell.api.unit.assign_unit(self.file)
element = ifcopenshell.api.root.create_entity(self.file, ifc_class="IfcWall")
theta = np.radians(30)
matrix = np.eye(4)
matrix[:2, :2] = [[np.cos(theta), -np.sin(theta)], [np.sin(theta), np.cos(theta)]]
ifcopenshell.api.geometry.edit_object_placement(self.file, product=element, matrix=matrix, is_si=False)
assert subject.get_element_value(element, "rotation_x") == pytest.approx(0.0)
assert subject.get_element_value(element, "rotation_y") == pytest.approx(0.0)
assert subject.get_element_value(element, "rotation_z") == pytest.approx(30.0)
element_without_placement = ifcopenshell.api.root.create_entity(self.file, ifc_class="IfcWall")
assert subject.get_element_value(element_without_placement, "rotation_z") is None
def test_selecting_using_a_multiple_key_query(self):
element = ifcopenshell.api.root.create_entity(self.file, ifc_class="IfcWall")
material = ifcopenshell.api.material.add_material(self.file, name="CON01")