Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-10 14:07:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't assert but just if-check for not terminating rule execution on very invalid files

Browse Source
This commit is contained in:
Thomas Krijnen
2023-06-01 14:06:41 +02:00
parent 9d869ebb6d
commit d60fbd2c09
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/express/rule_executor.py
+8 -4
View File
@@ -197,10 +197,14 @@ def run(f, logger):
type = type.declared_type() type = type.declared_type()
if isinstance(value, (list, tuple)): if isinstance(value, (list, tuple)):
assert isinstance(type, ifcopenshell.ifcopenshell_wrapper.aggregation_type) if isinstance(type, ifcopenshell.ifcopenshell_wrapper.aggregation_type):
ty = type.type_of_element() ty = type.type_of_element()
for v in value: for v in value:
check(v, ty, instance=inst) check(v, ty, instance=inst)
else:
# Let's hope a schema validation error was reported for this case
pass
elif isinstance(value, ifcopenshell.entity_instance): elif isinstance(value, ifcopenshell.entity_instance):
if isinstance( if isinstance(
S.declaration_by_name(value.is_a()), S.declaration_by_name(value.is_a()),