Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-10 09:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where removing an opening might remove an element twice

Browse Source
This commit is contained in:
Dion Moult
2021-09-09 12:38:25 +10:00
parent 55a220751b
commit d6aec719e5
4 changed files with 34 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/void/remove_opening.py
+4 -11
View File
@@ -9,15 +9,8 @@ class Usecase:
self.settings[key] = value
def execute(self):
to_remove = [] # See bug #1224
for rel in self.file.by_type("IfcRelVoidsElement"):
if rel.RelatedOpeningElement == self.settings["opening"]:
to_remove.append(rel)
break
for rel in self.file.by_type("IfcRelFillsElement"):
if rel.RelatingOpeningElement == self.settings["opening"]:
to_remove.append(rel)
break
for rel in self.settings["opening"].VoidsElements:
self.file.remove(rel)
for rel in self.settings["opening"].HasFillings:
self.file.remove(rel)
ifcopenshell.api.run("root.remove_product", self.file, product=self.settings["opening"])
for element in to_remove:
self.file.remove(element)