Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-22 20:02:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #2427. Don't treat missing mandatory attributes as fatal in IFC version migration

Browse Source
This commit is contained in:
Dion Moult
2022-09-20 22:46:07 +10:00
parent dd49c092c6
commit db9af13843
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/util/schema.py
+5 -4
View File
@@ -125,6 +125,8 @@ class Migrator:
} }
def migrate(self, element, new_file): def migrate(self, element, new_file):
if element.id() == 0:
return new_file.create_entity(element.is_a(), element.wrappedValue)
try: try:
return new_file.by_id(self.migrated_ids[element.id()]) return new_file.by_id(self.migrated_ids[element.id()])
except: except:
@@ -214,13 +216,12 @@ class Migrator:
for item in value: for item in value:
new_value.append(self.migrate(item, new_file)) new_value.append(self.migrate(item, new_file))
value = new_value value = new_value
setattr(new_element, attribute.name(), value) if value is not None:
setattr(new_element, attribute.name(), value)
def generate_default_value(self, attribute, new_file): def generate_default_value(self, attribute, new_file):
if attribute.name() in self.default_values: if attribute.name() in self.default_values:
return self.default_values[attribute.name()] return self.default_values[attribute.name()]
elif self.default_entities[attribute.name()]:
return self.default_entities[attribute.name()]
elif attribute.name() == "OwnerHistory": elif attribute.name() == "OwnerHistory":
self.default_entities[attribute.name()] = new_file.create_entity( self.default_entities[attribute.name()] = new_file.create_entity(
"IfcOwnerHistory", "IfcOwnerHistory",
@@ -249,4 +250,4 @@ class Migrator:
"CreationDate": int(time.time()), "CreationDate": int(time.time()),
}, },
) )
return self.default_entities[attribute.name()] return self.default_entities.get(attribute.name(), None)