From dcc52fc4e49c49eb0d72e4159c721cea91193df6 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Mon, 6 May 2024 18:09:32 +0500 Subject: [PATCH] pset.edit_pset not to fail silently on invalid enum values #4608 --- src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py b/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py index be3ed6c00a..01d5d9b2ea 100644 --- a/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py +++ b/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py @@ -260,6 +260,11 @@ class Usecase: prop.EnumerationReference.EnumerationValues = value.EnumerationReference.EnumerationValues prop.EnumerationValues = value.EnumerationValues + else: + raise ValueError( + f'Value "{self.settings["properties"][prop.Name]}" is not a valid value for enum property {prop.Name}.' + ) + if unit: prop.Unit = unit del self.settings["properties"][prop.Name]