Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-16 21:42:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3212. Bug where viewport camera bisection didn't have enough tolerance and sometimes wasn't visible.

Browse Source
This commit is contained in:
Dion Moult
2023-05-30 14:31:03 +10:00
parent 1d5891fde7
commit dddbf64e93
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blenderbim/blenderbim/bim/module/drawing/decoration.py
+4 -6
View File
@@ -60,7 +60,7 @@ class profile_consequential:
def stop(cls): def stop(cls):
cls.log() cls.log()
cls.start_time = None cls.start_time = None
print('\n'.join(cls.lines)) print("\n".join(cls.lines))
cls.lines = [] cls.lines = []
@@ -540,7 +540,6 @@ class BaseDecorator:
line_i += 1 if not reverse_lines_order else -1 line_i += 1 if not reverse_lines_order else -1
class DimensionDecorator(BaseDecorator): class DimensionDecorator(BaseDecorator):
"""Decorator for dimension objects """Decorator for dimension objects
- each edge of a segment with arrow - each edge of a segment with arrow
@@ -628,7 +627,6 @@ class DimensionDecorator(BaseDecorator):
text_offset_value = viewportDrawingScale * 3 text_offset_value = viewportDrawingScale * 3
for i0, i1 in indices: for i0, i1 in indices:
v0 = Vector(vertices[i0]) v0 = Vector(vertices[i0])
v1 = Vector(vertices[i1]) v1 = Vector(vertices[i1])
p0 = location_3d_to_region_2d(region, region3d, v0) p0 = location_3d_to_region_2d(region, region3d, v0)
@@ -1910,17 +1908,17 @@ class DecorationsHandler:
if not element.is_a("IfcAnnotation"): if not element.is_a("IfcAnnotation"):
continue continue
object_type = element.ObjectType object_type = element.ObjectType
if object_type == "DRAWING": if object_type == "DRAWING":
continue continue
if (dec := self.decorators.get(object_type, None)): if dec := self.decorators.get(object_type, None):
results.append((obj, dec)) results.append((obj, dec))
elif isinstance(obj.data, bpy.types.Mesh): elif isinstance(obj.data, bpy.types.Mesh):
results.append((obj, self.decorators["MISC"])) results.append((obj, self.decorators["MISC"]))
return results return results
def __call__(self, context): def __call__(self, context):
src/blenderbim/blenderbim/tool/drawing.py
+2 -1
View File
@@ -1593,7 +1593,8 @@ class Drawing(blenderbim.core.tool.Drawing):
plane_co = camera_matrix.translation plane_co = camera_matrix.translation
plane_no = camera_matrix.col[2].xyz plane_no = camera_matrix.col[2].xyz
global_offset = camera.matrix_world.col[2].xyz * -camera.data.clip_start # Bisect verts are offset by the clip (with 5mm tolerance) to ensure it is visible in the viewport.
global_offset = camera.matrix_world.col[2].xyz * (-camera.data.clip_start - 0.005)
bm = bmesh.new() bm = bmesh.new()
bm.from_mesh(obj.data) bm.from_mesh(obj.data)