Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-16 13:46:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes after merge

Browse Source
This commit is contained in:
Thomas Krijnen
2026-06-11 21:02:03 +02:00
parent 964fb045f7
commit df59c888fd
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/AbstractKernel.h
+2 -2
View File
@@ -161,7 +161,7 @@ namespace {
if (kernel->partial_success_is_success) { if (kernel->partial_success_is_success) {
std::string created_from; std::string created_from;
if (item->instance) { if (item->instance) {
created_from = " (created from " + item->instance->declaration().name() + ")"; created_from = " (created from " + item->instance.declaration().name() + ")";
} }
logger::error("No support for " + ifcopenshell::geometry::taxonomy::kind_to_string(item->kind()) + created_from + " in kernel " + kernel->geometry_library()); logger::error("No support for " + ifcopenshell::geometry::taxonomy::kind_to_string(item->kind()) + created_from + " in kernel " + kernel->geometry_library());
} }
@@ -187,7 +187,7 @@ namespace {
if (kernel->partial_success_is_success) { if (kernel->partial_success_is_success) {
std::string created_from; std::string created_from;
if (item->instance) { if (item->instance) {
created_from = " (created from " + item->instance->declaration().name() + ")"; created_from = " (created from " + item->instance.declaration().name() + ")";
} }
logger::error("No support (after considering item upgrade) for " + ifcopenshell::geometry::taxonomy::kind_to_string(item->kind()) + created_from + " in kernel " + kernel->geometry_library()); logger::error("No support (after considering item upgrade) for " + ifcopenshell::geometry::taxonomy::kind_to_string(item->kind()) + created_from + " in kernel " + kernel->geometry_library());
} }
src/ifcgeom/kernels/opencascade/faceset_helper.cpp
+2 -2
View File
@@ -171,12 +171,12 @@ IfcGeom::OpenCascadeKernel::faceset_helper::faceset_helper(
segments.push_back(std::make_pair(C, D)); segments.push_back(std::make_pair(C, D));
}); });
if (edge_sets.find({loop->external.get_value_or(false), segment_set}) != edge_sets.end()) { if (edge_sets.find({loop->external.value_or(false), segment_set}) != edge_sets.end()) {
duplicate_faces++; duplicate_faces++;
duplicates_.insert(loop->identity()); duplicates_.insert(loop->identity());
continue; continue;
} }
edge_sets.insert({loop->external.get_value_or(false), segment_set}); edge_sets.insert({loop->external.value_or(false), segment_set});
if (segments.size() >= 3) { if (segments.size() >= 3) {
for (auto& p : segments) { for (auto& p : segments) {
src/ifcgeom/mapping/mapping.cpp
+1 -1
View File
@@ -197,7 +197,7 @@ std::vector<express::Base> mapping::find_openings(const express::Base& inst) {
// Only aggregation, not nesting is considered. // Only aggregation, not nesting is considered.
break; break;
} }
express::Base rel_obdef; IfcSchema::IfcObjectDefinition rel_obdef;
try { try {
rel_obdef = decomposes.front().as<IfcSchema::IfcRelAggregates>().RelatingObject(); rel_obdef = decomposes.front().as<IfcSchema::IfcRelAggregates>().RelatingObject();
} catch (const std::exception&) { } catch (const std::exception&) {