Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-13 19:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

ifcviewer: F to frame selection from tree, debug coord dump

Browse Source 
Tree -> viewport selection was already wired (onTreeSelectionChanged
calls setSelectedObjectId), but pressing F afterwards routed to the
focused tree widget rather than the viewport, so framing didn't fire.
Add a window-level View > Frame Selected QAction with Qt::Key_F that
delegates to ViewportWindow::focusOnSelectedObject — works regardless
of which child widget has focus.  The viewport's own F handler stays
in place for when the viewport itself owns focus.

For debugging coordinate problems, add View > Print Selected Coords
(Ctrl+Shift+P) -> ViewportWindow::printSelectedObjectCoords, which
qInfo's:
  - a sample vertex (first vertex of the selected mesh, decoded on
    demand from the quantised VBO so no extra CPU storage is needed);
  - placement_transformation (the per-instance matrix that maps the
    sample vertex from mesh-local into the model's pre-georef frame);
  - global = CoordinateOperation . placement_transformation (where
    the IFC's own IfcCoordinateOperation has been folded in);
  - the sample vertex transformed through both matrices.

The print is a no-op when nothing is selected or GL hasn't initialised.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Dion Moult
2026-05-02 19:01:50 +10:00
parent 8f3eaa35d7
commit e0e143bab5
3 changed files with 100 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcviewer-full/MainWindow.cpp
+11
View File
@@ -201,6 +201,17 @@ void MainWindow::setupMenus() {
file_menu->addAction("&Quit", QKeySequence::Quit, qApp, &QApplication::quit);
auto* view_menu = menuBar()->addMenu("&View");
// F frames the current selection. The viewport already binds F in its
// own keyPressEvent for the case where it has focus; this duplicate at
// window level is so the shortcut still fires when the tree, property
// table, or any other child widget has keyboard focus.
view_menu->addAction("&Frame Selected", this, [this]() {
viewport_->focusOnSelectedObject();
}, QKeySequence(Qt::Key_F));
view_menu->addAction("Print Selected &Coords", this, [this]() {
viewport_->printSelectedObjectCoords();
}, QKeySequence("Ctrl+Shift+P"));
view_menu->addSeparator();
view_menu->addAction("Set &Home View", this, &MainWindow::onSetHomeView);
view_menu->addAction("&Go to Home View", this, &MainWindow::onGoHomeView);
}