Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-19 06:39:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix possible infinite recursion in bim.debug_active_drawing #4500

Browse Source 
also fixed the issue with mixed up results at the end of the operator execution
This commit is contained in:
Andrej730
2024-04-08 12:18:56 +05:00
parent 3357f89311
commit e21eaac3a2
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blenderbim/blenderbim/bim/module/debug/operator.py
+16 -6
View File
@@ -690,7 +690,7 @@ class DebugActiveDrawing(bpy.types.Operator):
pass pass
else: else:
self.report({"INFO"}, "No errors creating drawing, nothing to investigate.") self.report({"INFO"}, "No errors creating drawing, nothing to investigate.")
return return {"FINISHED"}
all_elements = [e for obj in context.visible_objects if (e := tool.Ifc.get_entity(obj))] all_elements = [e for obj in context.visible_objects if (e := tool.Ifc.get_entity(obj))]
all_elements = set(all_elements) all_elements = set(all_elements)
@@ -715,14 +715,24 @@ class DebugActiveDrawing(bpy.types.Operator):
def test_elements(elements: list[ifcopenshell.entity_instance], attempts: int = ATTEMPS) -> None: def test_elements(elements: list[ifcopenshell.entity_instance], attempts: int = ATTEMPS) -> None:
print(f"{CYAN}processing {len(elements)} elements{END}") print(f"{CYAN}processing {len(elements)} elements{END}")
if not elements:
print(f"Empty list of elements, will stop...")
return
n_elements = len(elements) n_elements = len(elements)
middle = int(n_elements / 2) middle = int(n_elements / 2)
chunk1, chunk2 = elements[:middle], elements[middle:] chunk1, chunk2 = elements[:middle], elements[middle:]
test_chunk_1 = drawing_fails_to_load(set(chunk1)) test_chunk_1 = drawing_fails_to_load(set(chunk1))
test_chunk_2 = drawing_fails_to_load(set(chunk2)) test_chunk_2 = drawing_fails_to_load(set(chunk2))
if not test_chunk_1 and not test_chunk_2: if (
if attempts == 0 or n_elements == 2: # both chunks do not fail anymore
(not test_chunk_1 and not test_chunk_2)
# or we have 1 element chunk that is still failing
or (test_chunk_1 and not chunk2)
or (test_chunk_2 and not chunk1)
):
if attempts == 0 or n_elements in (1, 2):
print(f"{GREEN}Couldn't narrow it down any further.{END}") print(f"{GREEN}Couldn't narrow it down any further.{END}")
print(f"It's some of the {n_elements} elements:") print(f"It's some of the {n_elements} elements:")
print(elements) print(elements)
@@ -731,19 +741,19 @@ class DebugActiveDrawing(bpy.types.Operator):
for element in elements: for element in elements:
test = drawing_fails_to_load(all_elements - {element}) test = drawing_fails_to_load(all_elements - {element})
if test: if test:
print(f"{GREEN}Excluding element fixed the drawing: {END}") print(f"{CYAN}Excluding element didn't fixed the drawing: {END}")
print(element) print(element)
else: else:
print(f"{CYAN}Excluding element didn't fixed the drawing: {END}") print(f"{GREEN}Excluding element fixed the drawing: {END}")
print(element) print(element)
else: else:
print(f"{CYAN}Will try to reshuffle elements and try again, attempt {ATTEMPS-attempts+1}/{ATTEMPS}") print(f"{CYAN}Will try to reshuffle elements and try again, attempt {ATTEMPS-attempts+1}/{ATTEMPS}")
attempts -= 1 attempts -= 1
random.shuffle(elements) random.shuffle(elements)
test_elements(elements, attempts) test_elements(elements, attempts)
return return
# if chunk fails we need to investigate it further
if test_chunk_1: if test_chunk_1:
test_elements(chunk1) test_elements(chunk1)