Split true north in API and Blender UI to be editable independent of georeferencing

They are two separate concepts, after all.
This commit is contained in:
Dion Moult
2024-06-23 23:19:27 +10:00
parent 013b138e5c
commit e295d596fe
11 changed files with 273 additions and 110 deletions
@@ -31,7 +31,7 @@ class TestEditGeoreferencing(test.bootstrap.IFC4):
ifcopenshell.api.georeference.edit_georeferencing(
self.file,
projected_crs={"Name": "EPSG:7856"},
map_conversion={"Eastings": 123.45, "Northings": 234.56},
coordinate_operation={"Eastings": 123.45, "Northings": 234.56},
)
crs = self.file.by_type("IfcProjectedCRS")[0]
assert crs.Name == "EPSG:7856"
@@ -39,15 +39,6 @@ class TestEditGeoreferencing(test.bootstrap.IFC4):
assert conversion.Eastings == 123.45
assert conversion.Northings == 234.56
def test_editing_true_north(self):
ifcopenshell.api.root.create_entity(self.file, ifc_class="IfcProject")
model = ifcopenshell.api.context.add_context(self.file, "Model")
plan = ifcopenshell.api.context.add_context(self.file, "Plan")
ifcopenshell.api.georeference.add_georeferencing(self.file)
ifcopenshell.api.georeference.edit_georeferencing(self.file, true_north=[0.0, 1.0])
assert model.TrueNorth[0] == (0.0, 1.0, 0.0)
assert plan.TrueNorth[0] == (0.0, 1.0)
class TestEditGeoreferencingIFC2X3(test.bootstrap.IFC2X3):
def test_editing_georeferencing(self):
@@ -56,7 +47,7 @@ class TestEditGeoreferencingIFC2X3(test.bootstrap.IFC2X3):
ifcopenshell.api.georeference.edit_georeferencing(
self.file,
projected_crs={"Name": "EPSG:7856"},
map_conversion={"Eastings": 123.45, "Northings": 234.56},
coordinate_operation={"Eastings": 123.45, "Northings": 234.56},
)
conversion = ifcopenshell.util.element.get_pset(project, "ePSet_MapConversion", verbose=True)
crs = ifcopenshell.util.element.get_pset(project, "ePSet_ProjectedCRS", verbose=True)
@@ -0,0 +1,38 @@
# IfcOpenShell - IFC toolkit and geometry engine
# Copyright (C) 2022 Dion Moult <dion@thinkmoult.com>
#
# This file is part of IfcOpenShell.
#
# IfcOpenShell is free software: you can redistribute it and/or modify
# it under the terms of the GNU Lesser General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# IfcOpenShell is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License
# along with IfcOpenShell. If not, see <http://www.gnu.org/licenses/>.
import numpy as np
import test.bootstrap
import ifcopenshell.api.root
import ifcopenshell.api.context
import ifcopenshell.api.georeference
import ifcopenshell.util.geolocation
class TestEditTrueNorth(test.bootstrap.IFC4):
def test_editing_true_north(self):
ifcopenshell.api.root.create_entity(self.file, ifc_class="IfcProject")
model = ifcopenshell.api.context.add_context(self.file, "Model")
plan = ifcopenshell.api.context.add_context(self.file, "Plan")
ifcopenshell.api.georeference.edit_true_north(self.file, true_north=[0.0, 1.0])
assert model.TrueNorth[0] == (0.0, 1.0, 0.0)
assert plan.TrueNorth[0] == (0.0, 1.0)
ifcopenshell.api.georeference.edit_true_north(self.file, true_north=[-0.5, 0.8660254])
assert np.isclose(ifcopenshell.util.geolocation.get_true_north(self.file), 30)
ifcopenshell.api.georeference.edit_true_north(self.file, true_north=30)
assert np.isclose(ifcopenshell.util.geolocation.get_true_north(self.file), 30)