typing

src/bonsai/bonsai/bim/module/boundary/operator.py

@@ -982,14 +982,17 @@ class AddBoundary(bpy.types.Operator, tool.Ifc.Operator):
         self.set_boundary_name(parent_boundary)
         return parent_boundary
 
-    def get_face_matrix(self, p1, p2, p3):
+    def get_face_matrix(self, p1: Vector, p2: Vector, p3: Vector) -> Matrix:
         edge1 = p2 - p1
         edge2 = p3 - p1
         normal = edge1.cross(edge2)
+        assert isinstance(normal, Vector)
+
         z_axis = normal.normalized()
         x_axis = p2 - p1
         x_axis.normalize()
         y_axis = z_axis.cross(x_axis)
+        assert isinstance(y_axis, Vector)
 
         mat = Matrix()
         mat.col[0][:3] = x_axis
@@ -1059,7 +1062,7 @@ class AddBoundary(bpy.types.Operator, tool.Ifc.Operator):
 
         return surface
 
-    def set_boundary_name(self, boundary):
+    def set_boundary_name(self, boundary: ifcopenshell.entity_instance):
         """
         By convention 1stLevel and 2ndLevel boundary have specific name and description
         See https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcRelSpaceBoundary.htm

src/bonsai/bonsai/bim/module/cost/operator.py

@@ -24,7 +24,7 @@ import bonsai.tool as tool
 from bpy_extras.io_utils import ImportHelper, ExportHelper
 import bonsai.tool as tool
 import bonsai.core.cost as core
-from typing import get_args, TYPE_CHECKING
+from typing import get_args, TYPE_CHECKING, Literal
 
 
 class AddCostSchedule(bpy.types.Operator, tool.Ifc.Operator):
@@ -695,6 +695,9 @@ class ExportCostSchedules(bpy.types.Operator, ExportHelper):
         default=True,
     )
 
+    if TYPE_CHECKING:
+        format: Literal["CSV", "XLSX", "ODS"]
+
     @property
     def filename_ext(self) -> str:
         return f".{self.format.lower()}"

src/bonsai/bonsai/bim/module/type/operator.py

@@ -24,11 +24,13 @@ import ifcopenshell.util.representation
 import ifcopenshell.util.type
 import ifcopenshell.util.unit
 import ifcopenshell.api
+import ifcopenshell.api.type
 import bonsai.bim.helper
 import bonsai.tool as tool
 import bonsai.core.geometry
 import bonsai.core.type as core
 import bonsai.core.root
+from typing import TYPE_CHECKING
 
 
 class AssignType(bpy.types.Operator, tool.Ifc.Operator):
@@ -38,15 +40,18 @@ class AssignType(bpy.types.Operator, tool.Ifc.Operator):
     relating_type: bpy.props.IntProperty()
     related_object: bpy.props.StringProperty()
 
+    if TYPE_CHECKING:
+        relating_type: int
+        related_object: str
+
     def _execute(self, context):
         relating_type = tool.Ifc.get().by_id(
             self.relating_type or int(context.active_object.BIMTypeProperties.relating_type)
         )
-        related_objects = (
-            [bpy.data.objects.get(self.related_object)]
-            if self.related_object
-            else context.selected_objects or [context.active_object]
-        )
+        if self.related_object:
+            related_objects = [bpy.data.objects[self.related_object]]
+        else:
+            related_objects = tool.Blender.get_selected_objects()
         model_props = tool.Model.get_model_props()
         for obj in related_objects:
             element = tool.Ifc.get_entity(obj)
@@ -63,17 +68,24 @@ class UnassignType(bpy.types.Operator, tool.Ifc.Operator):
     bl_options = {"REGISTER", "UNDO"}
     related_object: bpy.props.StringProperty()
 
+    if TYPE_CHECKING:
+        related_object: str
+
     def _execute(self, context):
         def exclude_callback(attribute):
             return attribute.is_a("IfcProfileDef") and attribute.ProfileName
 
         self.file = tool.Ifc.get()
-        objs = [bpy.data.objects.get(self.related_object)] if self.related_object else context.selected_objects
-        for obj in objs:
+        if self.related_object:
+            related_objects = [bpy.data.objects[self.related_object]]
+        else:
+            related_objects = tool.Blender.get_selected_objects()
+
+        for obj in related_objects:
             element = tool.Ifc.get_entity(obj)
             if not element or not element.is_a("IfcObject"):
                 continue
-            ifcopenshell.api.run("type.unassign_type", self.file, related_objects=[element])
+            ifcopenshell.api.type.unassign_type(self.file, related_objects=[element])
 
             if element.Representation:
                 new_active_representation = None

src/bonsai/bonsai/core/cost.py

@@ -337,7 +337,10 @@ def calculate_cost_item_resource_value(ifc: tool.Ifc, cost_item: ifcopenshell.en
 
 
 def export_cost_schedules(
-    cost: tool.Cost, filepath: str, format: str, cost_schedule: Union[ifcopenshell.entity_instance, None] = None
+    cost: tool.Cost,
+    filepath: str,
+    format: Literal["CSV", "ODS", "XLSX"],
+    cost_schedule: Union[ifcopenshell.entity_instance, None] = None,
 ) -> Union[str, None]:
     cost.play_sound()
     return cost.export_cost_schedules(filepath, format, cost_schedule)

src/bonsai/bonsai/tool/cost.py

@@ -29,6 +29,7 @@ import bonsai.bim.helper
 import json
 from pathlib import Path
 from typing import Optional, Any, Generator, Union, Literal, TYPE_CHECKING
+from typing_extensions import assert_never
 
 if TYPE_CHECKING:
     from bonsai.bim.module.cost.prop import BIMCostProperties, CostItemQuantity
@@ -652,7 +653,10 @@ class Cost(bonsai.core.tool.Cost):
 
     @classmethod
     def export_cost_schedules(
-        cls, filepath: str, format: str, cost_schedule: Optional[ifcopenshell.entity_instance] = None
+        cls,
+        filepath: str,
+        format: Literal["CSV", "ODS", "XLSX"],
+        cost_schedule: Optional[ifcopenshell.entity_instance] = None,
     ) -> Union[str, None]:
         import subprocess
         import os
@@ -680,6 +684,8 @@ class Cost(bonsai.core.tool.Cost):
 
             writer = Ifc5DXlsxWriter(file=tool.Ifc.get(), output=path, cost_schedule=cost_schedule)
             writer.write()
+        else:
+            assert_never(format)
         try:
             if path:
                 if sys.platform == "win32":