Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 06:58:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3547. Bug where using existing clippings were not preserved when editing profile or wall representations.

Browse Source
This commit is contained in:
Dion Moult
2023-08-08 22:35:27 +10:00
parent 706aa70899
commit e43347161a
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/geometry/add_profile_representation.py
+6 -2
View File
@@ -63,7 +63,11 @@ class Usecase:
def apply_clippings(self, first_operand): def apply_clippings(self, first_operand):
while self.settings["clippings"]: while self.settings["clippings"]:
clipping = self.settings["clippings"].pop() clipping = self.settings["clippings"].pop()
if clipping["operand_type"] == "IfcHalfSpaceSolid": if isinstance(clipping, ifcopenshell.entity_instance):
new = ifcopenshell.util.element.copy(self.file, clipping)
new.FirstOperand = first_operand
first_operand = new
elif clipping["operand_type"] == "IfcHalfSpaceSolid":
matrix = clipping["matrix"] matrix = clipping["matrix"]
second_operand = self.file.createIfcHalfSpaceSolid( second_operand = self.file.createIfcHalfSpaceSolid(
self.file.createIfcPlane( self.file.createIfcPlane(
@@ -81,7 +85,7 @@ class Usecase:
), ),
False, False,
) )
first_operand = self.file.create_entity(clipping["type"], "DIFFERENCE", first_operand, second_operand) first_operand = self.file.create_entity(clipping["type"], "DIFFERENCE", first_operand, second_operand)
return first_operand return first_operand
def convert_si_to_unit(self, co): def convert_si_to_unit(self, co):
src/ifcopenshell-python/ifcopenshell/api/geometry/add_wall_representation.py
+6 -2
View File
@@ -95,7 +95,11 @@ class Usecase:
def apply_clippings(self, first_operand): def apply_clippings(self, first_operand):
while self.settings["clippings"]: while self.settings["clippings"]:
clipping = self.settings["clippings"].pop() clipping = self.settings["clippings"].pop()
if clipping["operand_type"] == "IfcHalfSpaceSolid": if isinstance(clipping, ifcopenshell.entity_instance):
new = ifcopenshell.util.element.copy(self.file, clipping)
new.FirstOperand = first_operand
first_operand = new
elif clipping["operand_type"] == "IfcHalfSpaceSolid":
matrix = clipping["matrix"] matrix = clipping["matrix"]
second_operand = self.file.createIfcHalfSpaceSolid( second_operand = self.file.createIfcHalfSpaceSolid(
self.file.createIfcPlane( self.file.createIfcPlane(
@@ -113,7 +117,7 @@ class Usecase:
), ),
False, False,
) )
first_operand = self.file.create_entity(clipping["type"], "DIFFERENCE", first_operand, second_operand) first_operand = self.file.create_entity(clipping["type"], "DIFFERENCE", first_operand, second_operand)
return first_operand return first_operand
def convert_si_to_unit(self, co): def convert_si_to_unit(self, co):