Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-21 14:23:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

IfcTester now handles floating point precision checks

Browse Source
This commit is contained in:
Dion Moult
2022-09-10 23:31:21 +10:00
parent 7aad0fc119
commit e5e81c818e
2 changed files with 49 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifctester/ifctester/facet.py
+12 -2
View File
@@ -231,7 +231,12 @@ class Attribute(Facet):
break break
elif isinstance(self.value, str): elif isinstance(self.value, str):
cast_value = cast_to_value(self.value, value) cast_value = cast_to_value(self.value, value)
if value != cast_value: if isinstance(value, float) and isinstance(cast_value, float):
if value < cast_value * (1. - 1e-6) or value > cast_value * (1. + 1e-6):
is_pass = False
reason = {"type": "VALUE", "actual": value}
break
elif value != cast_value:
is_pass = False is_pass = False
reason = {"type": "VALUE", "actual": value} reason = {"type": "VALUE", "actual": value}
break break
@@ -420,7 +425,12 @@ class Property(Facet):
break break
elif isinstance(self.value, str): elif isinstance(self.value, str):
cast_value = cast_to_value(self.value, value) cast_value = cast_to_value(self.value, value)
if value != cast_value: if isinstance(value, float) and isinstance(cast_value, float):
if value < cast_value * (1. - 1e-6) or value > cast_value * (1. + 1e-6):
is_pass = False
reason = {"type": "VALUE", "actual": value}
break
elif value != cast_value:
is_pass = False is_pass = False
reason = {"type": "VALUE", "actual": value} reason = {"type": "VALUE", "actual": value}
break break
src/ifctester/test/test_facet.py
+37
View File
@@ -487,6 +487,33 @@ class TestAttribute:
expected=True, expected=True,
) )
facet = Attribute(name="RefractionIndex", value="42.")
ifc = ifcopenshell.file()
run(
"Floating point numbers are compared with a 1e-6 tolerance 1/4",
facet=facet,
inst=ifc.createIfcSurfaceStyleRefraction(RefractionIndex=42. * (1. + 1e-6)),
expected=True,
)
run(
"Floating point numbers are compared with a 1e-6 tolerance 2/4",
facet=facet,
inst=ifc.createIfcSurfaceStyleRefraction(RefractionIndex=42. * (1. - 1e-6)),
expected=True,
)
run(
"Floating point numbers are compared with a 1e-6 tolerance 3/4",
facet=facet,
inst=ifc.createIfcSurfaceStyleRefraction(RefractionIndex=42. * (1. + 2e-6)),
expected=False,
)
run(
"Floating point numbers are compared with a 1e-6 tolerance 4/4",
facet=facet,
inst=ifc.createIfcSurfaceStyleRefraction(RefractionIndex=42. * (1. - 2e-6)),
expected=False,
)
facet = Attribute(name="NumberOfRisers", value="42") facet = Attribute(name="NumberOfRisers", value="42")
ifc = ifcopenshell.file() ifc = ifcopenshell.file()
run( run(
@@ -903,6 +930,16 @@ class TestProperty:
facet = Property(propertySet="Foo_Bar", name="Foo", value="1.2345E3") facet = Property(propertySet="Foo_Bar", name="Foo", value="1.2345E3")
run("Only specifically formatted numbers are allowed 4/4", facet=facet, inst=element, expected=True) run("Only specifically formatted numbers are allowed 4/4", facet=facet, inst=element, expected=True)
facet = Property(propertySet="Foo_Bar", name="Foo", value="42.")
ifcopenshell.api.run("pset.edit_pset", ifc, pset=pset, properties={"Foo": ifc.createIfcReal(42. * (1. + 1e-6))})
run("Floating point numbers are compared with a 1e-6 tolerance 1/4", facet=facet, inst=element, expected=True)
ifcopenshell.api.run("pset.edit_pset", ifc, pset=pset, properties={"Foo": ifc.createIfcReal(42. * (1. - 1e-6))})
run("Floating point numbers are compared with a 1e-6 tolerance 2/4", facet=facet, inst=element, expected=True)
ifcopenshell.api.run("pset.edit_pset", ifc, pset=pset, properties={"Foo": ifc.createIfcReal(42. * (1. + 2e-6))})
run("Floating point numbers are compared with a 1e-6 tolerance 3/4", facet=facet, inst=element, expected=False)
ifcopenshell.api.run("pset.edit_pset", ifc, pset=pset, properties={"Foo": ifc.createIfcReal(42. * (1. - 2e-6))})
run("Floating point numbers are compared with a 1e-6 tolerance 4/4", facet=facet, inst=element, expected=False)
facet = Property(propertySet="Foo_Bar", name="Foo", value="TRUE") facet = Property(propertySet="Foo_Bar", name="Foo", value="TRUE")
ifcopenshell.api.run("pset.edit_pset", ifc, pset=pset, properties={"Foo": ifc.createIfcBoolean(False)}) ifcopenshell.api.run("pset.edit_pset", ifc, pset=pset, properties={"Foo": ifc.createIfcBoolean(False)})
run("Booleans must be specified as uppercase strings 1/3", facet=facet, inst=element, expected=False) run("Booleans must be specified as uppercase strings 1/3", facet=facet, inst=element, expected=False)