From e79a85a4fd310c5dbf3eac70006557a7195ca2fa Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Mon, 24 Feb 2025 12:28:20 +0500 Subject: [PATCH] bim.edit_container_attributes - remove deprecated operator Currently you can edit container name directly from spatial manager, so this operator is no longer needed (and it also was missing from UI either way). --- src/bonsai/bonsai/bim/module/spatial/__init__.py | 1 - src/bonsai/bonsai/bim/module/spatial/operator.py | 11 ----------- src/bonsai/bonsai/core/spatial.py | 5 ----- src/bonsai/bonsai/core/tool.py | 1 - src/bonsai/bonsai/tool/spatial.py | 9 --------- 5 files changed, 27 deletions(-) diff --git a/src/bonsai/bonsai/bim/module/spatial/__init__.py b/src/bonsai/bonsai/bim/module/spatial/__init__.py index 3194d18f3a..ee40768f08 100644 --- a/src/bonsai/bonsai/bim/module/spatial/__init__.py +++ b/src/bonsai/bonsai/bim/module/spatial/__init__.py @@ -26,7 +26,6 @@ classes = ( operator.DeleteContainer, operator.DereferenceStructure, operator.DisableEditingContainer, - operator.EditContainerAttributes, operator.EnableEditingContainer, operator.ExpandContainer, operator.ImportSpatialDecomposition, diff --git a/src/bonsai/bonsai/bim/module/spatial/operator.py b/src/bonsai/bonsai/bim/module/spatial/operator.py index dc68d95a8a..9caa736cbe 100644 --- a/src/bonsai/bonsai/bim/module/spatial/operator.py +++ b/src/bonsai/bonsai/bim/module/spatial/operator.py @@ -242,17 +242,6 @@ class ImportSpatialDecomposition(bpy.types.Operator): return {"FINISHED"} -class EditContainerAttributes(bpy.types.Operator): - bl_idname = "bim.edit_container_attributes" - bl_label = "Edit container attributes" - bl_options = {"REGISTER", "UNDO"} - container: bpy.props.IntProperty() - - def execute(self, context): - core.edit_container_attributes(tool.Spatial, entity=tool.Ifc.get().by_id(self.container)) - return {"FINISHED"} - - class ContractContainer(bpy.types.Operator): bl_idname = "bim.contract_container" bl_label = "Contract Container" diff --git a/src/bonsai/bonsai/core/spatial.py b/src/bonsai/bonsai/core/spatial.py index eff50ec2a3..d6097484bf 100644 --- a/src/bonsai/bonsai/core/spatial.py +++ b/src/bonsai/bonsai/core/spatial.py @@ -121,11 +121,6 @@ def import_spatial_decomposition(spatial: tool.Spatial) -> None: spatial.import_spatial_decomposition() -def edit_container_attributes(spatial: tool.Spatial, entity: ifcopenshell.entity_instance) -> None: - spatial.edit_container_attributes(entity) - spatial.import_spatial_decomposition() - - def contract_container(spatial: tool.Spatial, container: ifcopenshell.entity_instance) -> None: spatial.contract_container(container) spatial.import_spatial_decomposition() diff --git a/src/bonsai/bonsai/core/tool.py b/src/bonsai/bonsai/core/tool.py index b84e931871..d96b019df2 100644 --- a/src/bonsai/bonsai/core/tool.py +++ b/src/bonsai/bonsai/core/tool.py @@ -901,7 +901,6 @@ class Spatial: def deselect_objects(cls): pass def disable_editing(cls, obj): pass def duplicate_object_and_data(cls, obj): pass - def edit_container_attributes(cls, entity): pass def edit_container_name(cls, container, name): pass def enable_editing(cls, obj): pass def expand_container(cls, container): pass diff --git a/src/bonsai/bonsai/tool/spatial.py b/src/bonsai/bonsai/tool/spatial.py index 2f59e0b3da..26ae9db532 100644 --- a/src/bonsai/bonsai/tool/spatial.py +++ b/src/bonsai/bonsai/tool/spatial.py @@ -479,15 +479,6 @@ class Spatial(bonsai.core.tool.Spatial): for child in children or []: cls.import_spatial_element(child, level_index + 1) - @classmethod - def edit_container_attributes(cls, entity: ifcopenshell.entity_instance) -> None: - # TODO - obj = tool.Ifc.get_object(entity) - bonsai.core.geometry.edit_object_placement(tool.Ifc, tool.Geometry, tool.Surveyor, obj=obj) - name = bpy.context.scene.BIMSpatialDecompositionProperties.container_name - if name != entity.Name: - cls.edit_container_name(entity, name) - @classmethod def edit_container_name(cls, container: ifcopenshell.entity_instance, name: str) -> None: tool.Ifc.run("attribute.edit_attributes", product=container, attributes={"Name": name})