From e841defbd3388c544c5eee12eb97783102e404a1 Mon Sep 17 00:00:00 2001 From: Petru Conduraru Date: Sun, 12 Jul 2026 22:26:11 +0300 Subject: [PATCH] Fix ci-bonsai-daily: avoid tripled repo path in BDD link_ifc tests The update-extensions-repo-and-run-tests job has no top-level checkout, so the default workspace is already / = work/IfcOpenShell/IfcOpenShell. Cloning the repo into a subdir also named IfcOpenShell produced a third segment (.../IfcOpenShell/IfcOpenShell/IfcOpenShell), and the BDD feature fixtures template Path.cwd() into link_ifc file paths, yielding a FileNotFoundError on ~8 link_ifc scenarios in project.feature. Rename the manually-cloned directory to ifcopenshell_repo and update its three dependent references. Pure rename, no behaviour change beyond removing the path collision. Traced by exact command reconstruction; final confirmation is the next ci-bonsai-daily run (needs GitHub-hosted runners, not reproducible locally). This change was made with the assistance of an AI tool. Co-Authored-By: Claude Fable 5 --- .github/workflows/ci-bonsai-daily.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-bonsai-daily.yml b/.github/workflows/ci-bonsai-daily.yml index df7bff1fff..a1e773b3ea 100644 --- a/.github/workflows/ci-bonsai-daily.yml +++ b/.github/workflows/ci-bonsai-daily.yml @@ -128,12 +128,16 @@ jobs: blender --command extension install-file -r user_default -e $bonsai_zip blender --command extension list - git clone https://github.com/IfcOpenShell/IfcOpenShell.git IfcOpenShell + # NOTE: cloned into "ifcopenshell_repo" (not "IfcOpenShell") to avoid nesting under + # the runner's default workspace, which is already .../work/IfcOpenShell/IfcOpenShell. + # Naming this clone "IfcOpenShell" produced a tripled .../IfcOpenShell/IfcOpenShell/IfcOpenShell + # path that broke test fixture path resolution (e.g. bim.link_ifc FileNotFoundError). + git clone https://github.com/IfcOpenShell/IfcOpenShell.git ifcopenshell_repo # Reregister Bonsai. # Note that running it in background might miss some errors # (e.g. tools are not registered in background mode). - blender --background --python IfcOpenShell/src/bonsai/scripts/reregister_bonsai.py + blender --background --python ifcopenshell_repo/src/bonsai/scripts/reregister_bonsai.py # Install sverchok. wget -q -O sverchok.zip https://github.com/nortikin/sverchok/archive/refs/heads/master.zip @@ -145,7 +149,7 @@ jobs: blender --command extension install-file -r user_default sverchok.zip # Install ifcsverchok. - cd IfcOpenShell/src/ifcsverchok + cd ifcopenshell_repo/src/ifcsverchok make dist sverchok_zip="$(pwd)/dist/$(ls dist)" blender --command extension install-file -r user_default $sverchok_zip @@ -178,7 +182,7 @@ jobs: blender --online-mode --command extension sync blender --online-mode --command extension install --enable --sync sun_position - cd IfcOpenShell/src/bonsai + cd ifcopenshell_repo/src/bonsai pip install -r requirements-dev.txt blender --background --python scripts/setup_pytest.py blender --python-expr "import bonsai; print(bonsai.bbim_semver); import ifcopenshell; print(ifcopenshell.version)" --background