From e89d195f9bff9f2360778e7961ba3e53695d1746 Mon Sep 17 00:00:00 2001
From: Moritz Amberger <moritz.amberger@ait.ac.at>
Date: Wed, 18 Dec 2024 16:23:32 +0100
Subject: [PATCH] moved full_schema, is_strcit, should_expand,
 should_get_inverse, should_get_psets. should_get_geometry and
 should_skip_geometry_data to the Patcher class definition. deleted those
 parameters from the patch definition so that users are able to set them by
 themselves. removed the hardcoded tmp-File for the db_file name

---
 src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py | 27 +++++++++++++++---------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py b/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py
index f382bc6a18..de25c3f9ca 100644
--- a/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py
+++ b/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py
@@ -61,6 +61,13 @@ class Patcher:
         username: str = "root",
         password: str = "pass",
         database: str = "test",
+        full_schema: bool = True,
+        is_strict: bool = False,
+        should_expand: bool = False,
+        should_get_inverses: bool = True,
+        should_get_psets: bool = True,
+        should_get_geometry: bool = True,
+        should_skip_geometry_data: bool = False,
     ):
         """Convert an IFC-SPF model to SQLite or MySQL.
 
@@ -105,20 +112,20 @@ class Patcher:
         self.password = password
         self.database = database
 
-    def patch(self) -> None:
-        self.full_schema = True  # Set true for ifcopenshell.sqlite
-        self.is_strict = False
-        self.should_expand = False  # Set false for ifcopenshell.sqlite
-        self.should_get_inverses = True  # Set true for ifcopenshell.sqlite
-        self.should_get_psets = True
-        self.should_get_geometry = True  # Set true for ifcopenshell.sqlite
-        self.should_skip_geometry_data = False  # Set false for ifcopenshell.sqlite
+        # Configuration Values
+        self.full_schema = full_schema
+        self.is_strict = is_strict
+        self.should_expand = should_expand
+        self.should_get_inverses = should_get_inverses
+        self.should_get_psets = should_get_psets
+        self.should_get_geometry = should_get_geometry
+        self.should_skip_geometry_data = should_skip_geometry_data
 
+    def patch(self) -> None:
         self.schema = ifcopenshell.ifcopenshell_wrapper.schema_by_name(self.file.schema)
 
         if self.sql_type == "sqlite":
-            tmp = tempfile.NamedTemporaryFile(delete=False, suffix=".ifcsqlite")
-            db_file = tmp.name
+            db_file = self.database  # Use the given datapath
             self.db = sqlite3.connect(db_file)
             self.c = self.db.cursor()
             self.file_patched = db_file