Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-09 17:31:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ridiculous bug where util.element.get_container didn't consider all parents and therefore didn't correctly contain feature elements in the spatial hierarchy

Browse Source
This commit is contained in:
Dion Moult
2025-01-30 18:44:27 +11:00
parent abec29af7f
commit eaaec4a12d
3 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/util/element.py
+9 -16
View File
@@ -926,23 +926,16 @@ def get_container(
return container
if container.is_a(ifc_class):
return container
else:
aggregate = get_aggregate(element)
if aggregate:
return get_container(aggregate, should_get_direct)
nest = get_nest(element)
if nest:
return get_container(nest, should_get_direct)
if (
contained_in_structure := getattr(element, "ContainedInStructure", None)
) is not None and contained_in_structure:
container = contained_in_structure[0].RelatingStructure
if not ifc_class:
elif contained_in_structure := getattr(element, "ContainedInStructure", None):
container = contained_in_structure[0].RelatingStructure
if not ifc_class:
return container
while container:
if container.is_a(ifc_class):
return container
while container:
if container.is_a(ifc_class):
return container
container = get_aggregate(container)
container = get_aggregate(container)
elif parent := get_parent(element):
return get_container(parent, should_get_direct)
def get_referenced_structures(element: ifcopenshell.entity_instance) -> list[ifcopenshell.entity_instance]: