Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-16 21:42:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #1538. Bug when absolute coordinates are detected from a coordinate list.

Browse Source
This commit is contained in:
Dion Moult
2021-06-26 17:09:44 +10:00
parent 6e4e6a88a4
commit ebfb29d6da
1 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blenderbim/blenderbim/bim/import_ifc.py
+8 -11
View File
@@ -383,13 +383,10 @@ class IfcImporter:
def is_point_far_away(self, point): def is_point_far_away(self, point):
# Arbitrary threshold based on experience # Arbitrary threshold based on experience
coords = point
if hasattr(point, "Coordinates"): if hasattr(point, "Coordinates"):
return ( coords = point.Coordinates
abs(point.Coordinates[0]) > 1000000 return abs(coords[0]) > 1000000 or abs(coords[1]) > 1000000 or abs(coords[2]) > 1000000
or abs(point.Coordinates[1]) > 1000000
or abs(point.Coordinates[2]) > 1000000
)
return abs(point[0]) > 1000000 or abs(point[1]) > 1000000 or abs(point[2]) > 1000000
def process_element_filter(self): def process_element_filter(self):
if not self.ifc_import_settings.ifc_selector: if not self.ifc_import_settings.ifc_selector:
@@ -509,18 +506,18 @@ class IfcImporter:
elements_checked = 0 elements_checked = 0
# If more than these points aren't far away, the file probably isn't absolutely positioned # If more than these points aren't far away, the file probably isn't absolutely positioned
element_checking_threshold = 100 element_checking_threshold = 100
try: if self.file.schema == "IFC2X3":
point_lists = self.file.by_type("IfcCartesianPointList3D")
except:
# IFC2X3 does not have IfcCartesianPointList3D # IFC2X3 does not have IfcCartesianPointList3D
point_lists = [] point_lists = []
else:
point_lists = self.file.by_type("IfcCartesianPointList3D")
for point_list in point_lists: for point_list in point_lists:
elements_checked += 1 elements_checked += 1
if elements_checked > element_checking_threshold: if elements_checked > element_checking_threshold:
return return
for i, point in enumerate(point_list.CoordList): for i, point in enumerate(point_list.CoordList):
if len(point) == 3 and self.is_point_far_away(point): if len(point) == 3 and self.is_point_far_away(point):
return point[0] return point
for point in self.file.by_type("IfcCartesianPoint"): for point in self.file.by_type("IfcCartesianPoint"):
is_used_in_placement = False is_used_in_placement = False
@@ -534,7 +531,7 @@ class IfcImporter:
if elements_checked > element_checking_threshold: if elements_checked > element_checking_threshold:
return return
if len(point.Coordinates) == 3 and self.is_point_far_away(point): if len(point.Coordinates) == 3 and self.is_point_far_away(point):
return point[0] return point.Coordinates
def apply_blender_offset_to_matrix(self, matrix): def apply_blender_offset_to_matrix(self, matrix):
props = bpy.context.scene.BIMGeoreferenceProperties props = bpy.context.scene.BIMGeoreferenceProperties