fixed bug migrating attributes to older ifc version (after 8728fa3)

src/ifcopenshell-python/ifcopenshell/util/schema.py

@@ -264,7 +264,7 @@ class Migrator:
                 equivalent = attributes_mapping[new_element.is_a()][attribute.name()]
             if hasattr(element, equivalent):
                 # print("Equivalent found", equivalent)
-                value = getattr(element, equivalent)
+                return getattr(element, equivalent)
             else:
                 return
         except Exception as e:
@@ -275,9 +275,7 @@ class Migrator:
             )
             raise e
 
-    def migrate_attribute(
+    def migrate_attribute(self, attribute, element, new_file: ifcopenshell.file, new_element, new_element_schema):
-        self, attribute, element, new_file: ifcopenshell.file, new_element, new_element_schema
-    ):
         # NOTE: `attribute` is an attribute in new file schema
         # print("Migrating attribute", element, new_element, attribute.name())
         old_file = element.wrapped_data.file
@@ -311,6 +309,14 @@ class Migrator:
             except:  # We tried our best
                 return
 
+        elif new_file.schema == "IFC4" and old_file.schema == "IFC4X3":
+            try:
+                value = self.find_equivalent_attribute(
+                    new_element, attribute, element, self.attributes_mapping[("IFC4X3", "IFC4")], reverse_mapping=True
+                )
+            except:  # We tried our best
+                return
+
         try:
             value
         except UnboundLocalError:

src/ifcopenshell-python/test/util/test_schema.py

@@ -0,0 +1,74 @@
+# IfcOpenShell - IFC toolkit and geometry engine
+# Copyright (C) 2021 Dion Moult <dion@thinkmoult.com>
+#
+# This file is part of IfcOpenShell.
+#
+# IfcOpenShell is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# IfcOpenShell is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with IfcOpenShell.  If not, see <http://www.gnu.org/licenses/>.
+
+import pytest
+import test.bootstrap
+import ifcopenshell.api
+import ifcopenshell.util.schema as subject
+
+
+class TestMigrator(test.bootstrap.IFC4):
+    def test_migrate_element_using_attribute_mapping_ifc4_ifc4x3(self):
+        ifc4_file = ifcopenshell.api.run("project.create_file")
+        original_element = ifc4_file.createIfcWorkTime(Start="2024-01-01", Finish="2024-01-01")
+        ifc4x3_file = ifcopenshell.api.run("project.create_file", version="IFC4X3")
+
+        migrator = subject.Migrator()
+        for element in ifc4_file:
+            migrator.migrate(element, ifc4x3_file)
+
+        new_element = ifc4x3_file.by_type(original_element.is_a())[0]
+        assert original_element.Start == new_element.StartDate
+        assert original_element.Finish == new_element.FinishDate
+
+    def test_migrate_element_using_attribute_mapping_ifc4x3_ifc4(self):
+        ifc4x3_file = ifcopenshell.api.run("project.create_file", version="IFC4X3")
+        original_element = ifc4x3_file.createIfcWorkTime(StartDate="2024-01-01", FinishDate="2024-01-01")
+        ifc4_file = ifcopenshell.api.run("project.create_file")
+
+        migrator = subject.Migrator()
+        for element in ifc4x3_file:
+            migrator.migrate(element, ifc4_file)
+
+        new_element = ifc4_file.by_type(original_element.is_a())[0]
+        assert original_element.StartDate == new_element.Start
+        assert original_element.FinishDate == new_element.Finish
+
+    def test_migrate_element_using_attribute_mapping_ifc2x3_ifc4(self):
+        ifc2x3_file = ifcopenshell.api.run("project.create_file", version="IFC2X3")
+        original_element = ifc2x3_file.createIfcImageTexture(TextureType="SPECULAR")
+        ifc4_file = ifcopenshell.api.run("project.create_file")
+
+        migrator = subject.Migrator()
+        for element in ifc2x3_file:
+            migrator.migrate(element, ifc4_file)
+
+        new_element = ifc4_file.by_type(original_element.is_a())[0]
+        assert original_element.TextureType == new_element.Mode
+
+    def test_migrate_element_using_attribute_mapping_ifc4_ifc2x3(self):
+        ifc4_file = ifcopenshell.api.run("project.create_file")
+        original_element = ifc4_file.createIfcImageTexture(Mode="SPECULAR")
+        ifc2x3_file = ifcopenshell.api.run("project.create_file", version="IFC2X3")
+
+        migrator = subject.Migrator()
+        for element in ifc4_file:
+            migrator.migrate(element, ifc2x3_file)
+
+        new_element = ifc2x3_file.by_type(original_element.is_a())[0]
+        assert original_element.Mode == new_element.TextureType