From ed8a31c54bc4c1afb69fd511fc361ed94c54935f Mon Sep 17 00:00:00 2001
From: Andrej730 <azhilenkov@gmail.com>
Date: Thu, 7 Aug 2025 12:12:33 +0500
Subject: [PATCH] Update ignored settings structs in IfcPython.i #6976

---
 .../ifcopenshell/ifcopenshell_wrapper.pyi     | 25 -------------------
 .../test/test_create_shape.py                 |  8 ++++--
 src/ifcwrap/IfcPython.i                       | 17 +++++++++++--
 3 files changed, 21 insertions(+), 29 deletions(-)

diff --git a/src/ifcopenshell-python/ifcopenshell/ifcopenshell_wrapper.pyi b/src/ifcopenshell-python/ifcopenshell/ifcopenshell_wrapper.pyi
index 2c0a687397..7c0939fa60 100644
--- a/src/ifcopenshell-python/ifcopenshell/ifcopenshell_wrapper.pyi
+++ b/src/ifcopenshell-python/ifcopenshell/ifcopenshell_wrapper.pyi
@@ -135,11 +135,6 @@ class BRepElement(Element):
     @property
     def volume(self): ...
 
-class CgalEmitOriginalEdges:
-    name: Any
-    description: Any
-    defaultvalue: Any
-
 class ColladaSerializer(WriteOnlyGeometrySerializer):
     def finalize(self): ...
     def isTesselated(self): ...
@@ -150,11 +145,6 @@ class ColladaSerializer(WriteOnlyGeometrySerializer):
     def write(self, *args): ...
     def writeHeader(self): ...
 
-class ComputeCurvature:
-    name: Any
-    description: Any
-    defaultvalue: Any
-
 class ConversionResult:
     def ItemId(self): ...
     def Placement(self): ...
@@ -273,16 +263,6 @@ class Element:
 class FileSchema(HeaderEntity):
     schema_identifiers: Any
 
-class FunctionStepParam:
-    name: Any
-    description: Any
-    defaultvalue: Any
-
-class FunctionStepType:
-    name: Any
-    description: Any
-    defaultvalue: Any
-
 class GeometrySerializer:
     READ_BREP: Any
     READ_TRIANGULATION: Any
@@ -566,11 +546,6 @@ class TriangulationElement(Element):
     def geometry(self) -> Triangulation: ...
     def geometry_pointer(self): ...
 
-class TriangulationType:
-    name: Any
-    description: Any
-    defaultvalue: Any
-
 class TtlWktSerializer(WriteOnlyGeometrySerializer):
     def finalize(self): ...
     def isTesselated(self): ...
diff --git a/src/ifcopenshell-python/test/test_create_shape.py b/src/ifcopenshell-python/test/test_create_shape.py
index 5464aad855..57ffa0b78b 100644
--- a/src/ifcopenshell-python/test/test_create_shape.py
+++ b/src/ifcopenshell-python/test/test_create_shape.py
@@ -16,7 +16,9 @@ from typing import get_args
 class TestGeomSettings:
     def test_settings(self):
         settings = ifcopenshell.geom.settings()
-        assert set(get_args(ifcopenshell.geom.SETTING)) == set(settings.setting_names())
+        assert set(get_args(ifcopenshell.geom.SETTING)) == set(
+            settings.setting_names()
+        ), "Also need to update IfcPython.i, if new settings were added/removed."
 
         assert "use-python-opencascade" in settings.setting_names()
         assert settings.get(settings.USE_PYTHON_OPENCASCADE) is False
@@ -38,7 +40,9 @@ class TestGeomSettings:
 
     def test_serializer_settings(self):
         settings = ifcopenshell.geom.serializer_settings()
-        assert set(get_args(ifcopenshell.geom.SERIALIZER_SETTING)) == set(settings.setting_names())
+        assert set(get_args(ifcopenshell.geom.SERIALIZER_SETTING)) == set(
+            settings.setting_names()
+        ), "Also need to update IfcPython.i, if new settings were added/removed."
 
         # Only for settings.
         assert "use-python-opencascade" not in settings.setting_names()
diff --git a/src/ifcwrap/IfcPython.i b/src/ifcwrap/IfcPython.i
index 7140481c2b..51b0969591 100644
--- a/src/ifcwrap/IfcPython.i
+++ b/src/ifcwrap/IfcPython.i
@@ -94,6 +94,7 @@
 %ignore loop_to_function_item_upgrade_impl;
 
 // settings, can this done more generally?
+// GeometrySerializer.h
 %ignore UseElementNames;
 %ignore UseElementGuids;
 %ignore UseElementStepIds;
@@ -103,6 +104,7 @@
 %ignore FloatingPointDigits;
 %ignore BaseUri;
 %ignore WktUseSection;
+// ConversionSettings.h
 %ignore MesherLinearDeflection;
 %ignore MesherAngularDeflection;
 %ignore ReorientShells;
@@ -137,14 +139,25 @@
 %ignore SiteLocalPlacement;
 %ignore BuildingLocalPlacement;
 %ignore NoParallelMapping;
+%ignore PermissiveShapeReuse;
 %ignore ForceSpaceTransparency;
 %ignore CircleSegments;
+%ignore CgalSmoothAngleDegrees;
 %ignore KeepBoundingBoxes;
 %ignore SurfaceColour;
-%ignore PiecewiseStepType;
-%ignore PiecewiseStepParam;
+%ignore ComputeCurvature;
+%ignore FunctionStepType;
+%ignore FunctionStepParam;
 %ignore ModelOffset;
 %ignore ModelRotation;
+%ignore TriangulationType;
+%ignore CgalEmitOriginalEdges;
+%ignore OcctNoCleanTriangulation;
+%ignore CacheShapes;
+%ignore DeferProcessingFirstElement;
+%ignore MaxOffset;
+%ignore MaxOffsetDeviation;
+%ignore ApplyOffset;
 
 // Triangulated representation helper struct
 %ignore EdgeKey;