mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-09 17:31:45 +00:00
Add system assignment check
@aothms Is there a way to check against IFC formal propositions ? Example for [IfcZone](http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcZone.htm#5.4.3.82.4-Formal-propositions) @Moult Should I move is_assignable to an util ?
This commit is contained in:
@@ -20,6 +20,33 @@ import ifcopenshell
|
|||||||
import ifcopenshell.api
|
import ifcopenshell.api
|
||||||
|
|
||||||
|
|
||||||
|
ASSIGNABLE_DICT = {
|
||||||
|
"IfcZone": ("IfcZone", "IfcSpace", "IfcSpatialZone"),
|
||||||
|
"IfcBuiltSystem": (
|
||||||
|
"IfcBuiltElement",
|
||||||
|
"IfcFurnishingElement",
|
||||||
|
"IfcElementAssembly",
|
||||||
|
"IfcTransportElement",
|
||||||
|
),
|
||||||
|
"IfcBuildingSystem": (
|
||||||
|
"IfcBuildingElement",
|
||||||
|
"IfcFurnishingElement",
|
||||||
|
"IfcElementAssembly",
|
||||||
|
"IfcTransportElement",
|
||||||
|
),
|
||||||
|
"IfcDistributionSystem": ("IfcDistributionElement",),
|
||||||
|
"IfcStructuralAnalysisModel": ("IfcStructuralMember", "IfcStructuralConnection"),
|
||||||
|
"IfcGroup": ("IfcObjectDefinition",),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def is_assignable(product, system) -> bool:
|
||||||
|
for assignable in ASSIGNABLE_DICT.get(system.is_a(), ()):
|
||||||
|
if product.is_a(assignable):
|
||||||
|
return True
|
||||||
|
return False
|
||||||
|
|
||||||
|
|
||||||
class Usecase:
|
class Usecase:
|
||||||
def __init__(self, file, **settings):
|
def __init__(self, file, **settings):
|
||||||
self.file = file
|
self.file = file
|
||||||
@@ -31,6 +58,11 @@ class Usecase:
|
|||||||
self.settings[key] = value
|
self.settings[key] = value
|
||||||
|
|
||||||
def execute(self):
|
def execute(self):
|
||||||
|
system = self.settings["system"]
|
||||||
|
product = self.settings["product"]
|
||||||
|
if not is_assignable(product, system):
|
||||||
|
raise TypeError(f"You cannot assign an {product.is_a()} to an {system.is_a()}")
|
||||||
|
|
||||||
if not self.settings["system"].IsGroupedBy:
|
if not self.settings["system"].IsGroupedBy:
|
||||||
return self.file.create_entity(
|
return self.file.create_entity(
|
||||||
"IfcRelAssignsToGroup",
|
"IfcRelAssignsToGroup",
|
||||||
@@ -39,7 +71,7 @@ class Usecase:
|
|||||||
"OwnerHistory": ifcopenshell.api.run("owner.create_owner_history", self.file),
|
"OwnerHistory": ifcopenshell.api.run("owner.create_owner_history", self.file),
|
||||||
"RelatedObjects": [self.settings["product"]],
|
"RelatedObjects": [self.settings["product"]],
|
||||||
"RelatingGroup": self.settings["system"],
|
"RelatingGroup": self.settings["system"],
|
||||||
}
|
},
|
||||||
)
|
)
|
||||||
rel = self.settings["system"].IsGroupedBy[0]
|
rel = self.settings["system"].IsGroupedBy[0]
|
||||||
related_objects = set(rel.RelatedObjects) or set()
|
related_objects = set(rel.RelatedObjects) or set()
|
||||||
|
|||||||
@@ -39,11 +39,20 @@ class TestGetElementSystems(test.bootstrap.IFC4):
|
|||||||
|
|
||||||
def test_do_not_get_non_services_groups(self):
|
def test_do_not_get_non_services_groups(self):
|
||||||
element = ifcopenshell.api.run("root.create_entity", self.file, ifc_class="IfcPump")
|
element = ifcopenshell.api.run("root.create_entity", self.file, ifc_class="IfcPump")
|
||||||
ifcopenshell.api.run("system.assign_system", self.file, product=element, system=self.file.createIfcGroup())
|
|
||||||
ifcopenshell.api.run("system.assign_system", self.file, product=element, system=self.file.createIfcZone())
|
|
||||||
ifcopenshell.api.run(
|
ifcopenshell.api.run(
|
||||||
"system.assign_system", self.file, product=element, system=self.file.createIfcStructuralAnalysisModel()
|
"system.assign_system",
|
||||||
|
self.file,
|
||||||
|
product=element,
|
||||||
|
system=self.file.createIfcGroup(),
|
||||||
)
|
)
|
||||||
|
for not_assignable_system_class in ("IfcZone", "IfcStructuralAnalysisModel"):
|
||||||
|
with pytest.raises(TypeError):
|
||||||
|
ifcopenshell.api.run(
|
||||||
|
"system.assign_system",
|
||||||
|
self.file,
|
||||||
|
product=element,
|
||||||
|
system=self.file.create_entity(not_assignable_system_class),
|
||||||
|
)
|
||||||
assert not subject.get_element_systems(element)
|
assert not subject.get_element_systems(element)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user