From f0dbb535d3828477df7f4bdca5681d7ca3606011 Mon Sep 17 00:00:00 2001 From: Richard Brice <37087370+RickBrice@users.noreply.github.com> Date: Mon, 23 Oct 2023 08:22:03 -0700 Subject: [PATCH] Removed assert, added Logger::Warning and Logger::Error. Made treatment of unexpected data more permissive --- src/ifcgeom/mapping/IfcLinearPlacement.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/ifcgeom/mapping/IfcLinearPlacement.cpp b/src/ifcgeom/mapping/IfcLinearPlacement.cpp index 45f3e46010..0e3bb1a5d6 100644 --- a/src/ifcgeom/mapping/IfcLinearPlacement.cpp +++ b/src/ifcgeom/mapping/IfcLinearPlacement.cpp @@ -34,10 +34,6 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcLinearPlacement* inst) { IfcSchema::IfcLinearPlacement* current = (IfcSchema::IfcLinearPlacement*)inst; auto m4 = taxonomy::make(); -#if defined SCHEMA_HAS_IfcAxis2PlacementLinear - // IfcLinearPlacement was added in IFC 4.1 but it had an Orientation attribute of type IfcOrientationExpression, which when combined with other - // attributes was similar to IfcAxis2PlacementLinear. IFC 4.1 and IFC 4.2 have been withdrawn so I'm not going to try to implement linear placement for them. - // For this reason the preprocessor skips this code if SCHEMA_HAS_IfcAxix2PlacementLinear is not defined for (;;) { IfcSchema::IfcAxis2PlacementLinear* relplacement = current->RelativePlacement(); @@ -84,8 +80,8 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcLinearPlacement* inst) { } } - // @todo: rb - not sure what this means... it came from IfcLocalPlacement - // m4->components() = offset_and_rotation_ * m4->components(); + // @todo: rb - not sure what this means... it came from IfcLocalPlacement + // m4->components() = offset_and_rotation_ * m4->components(); return m4;