diff --git a/src/ifcparse/IfcParse.cpp b/src/ifcparse/IfcParse.cpp index bc6df697af..07179ace5c 100644 --- a/src/ifcparse/IfcParse.cpp +++ b/src/ifcparse/IfcParse.cpp @@ -1661,14 +1661,15 @@ void IfcParse::impl::in_memory_file_storage::read_from_stream(IfcParse::FileRead bytype_excl_[ty]->push(instance); } - if (byid_.find(current_id) != byid_.end()) { + // byidentity_[instance->identity()] = instance; + if (!byid_.insert({(uint32_t) current_id, instance }).second) { std::stringstream ss; ss << "Overwriting instance with name #" << current_id; logger().Message(Logger::LOG_WARNING, "SYN", 18, ss.str()); - } - // byidentity_[instance->identity()] = instance; - byid_.insert({(uint32_t) current_id, instance }); + // insert() is a no-op on a duplicate key; instance is already referenced by byguid_/bytype_excl_ above, so keep it owned here instead of leaking it. + duplicate_id_instances_.emplace_back(instance); + } // @nb cannot assign to byid_; // byid_[current_id] = instance; diff --git a/src/ifcparse/storage.h b/src/ifcparse/storage.h index 8c46d59640..b64d609cfb 100644 --- a/src/ifcparse/storage.h +++ b/src/ifcparse/storage.h @@ -199,6 +199,9 @@ namespace IfcParse { return std::move(read_simple_type_instances); } + // Entities rejected by byid_.insert() on a duplicate #id; kept alive here since byguid_/bytype_excl_ already reference them. + std::vector> duplicate_id_instances_; + IfcParse::IfcSpfLexer* tokens; std::reference_wrapper logger_; // IfcParse::FileReader* stream;