Old annotation systems now creates IFC elements again. Also text and misc annotations now work again with new system. See #1153.

src/ifcopenshell-python/ifcopenshell/api/geometry/add_representation.py

@@ -48,7 +48,7 @@ class Usecase:
         for modifier in self.settings["blender_object"].modifiers:
             if modifier.type == "BOOLEAN":
                 modifier.show_viewport = False
-            
+
         if self.settings["should_force_triangulation"]:
             mesh = self.settings["blender_object"].evaluated_get(bpy.context.evaluated_depsgraph_get()).to_mesh()
             bm = bmesh.new()
@@ -119,6 +119,41 @@ class Usecase:
         elif self.settings["context"].ContextIdentifier == "SurveyPoints":
             pass
 
+    def create_text_representation(self):
+        return self.file.createIfcShapeRepresentation(
+            self.settings["context"],
+            self.settings["context"].ContextIdentifier,
+            "Annotation2D",
+            [self.create_text()],
+        )
+
+    def create_text(self):
+        text = self.settings["geometry"]
+        if text.align_y in ["TOP_BASELINE", "BOTTOM_BASELINE", "BOTTOM"]:
+            y = "bottom"
+        elif text.align_y == "CENTER":
+            y = "middle"
+        elif text.align_y == "TOP":
+            y = "top"
+
+        if text.align_x == "LEFT":
+            x = "left"
+        elif text.align_x == "CENTER":
+            x = "middle"
+        elif text.align_x == "RIGHT":
+            x = "right"
+
+        origin = self.file.createIfcAxis2Placement3D(
+            self.file.createIfcCartesianPoint((0.0, 0.0, 0.0)),
+            self.file.createIfcDirection((0.0, 0.0, 1.0)),
+            self.file.createIfcDirection((1.0, 0.0, 0.0)),
+        )
+
+        # TODO: Planar extent right now is wrong ...
+        return self.file.createIfcTextLiteralWithExtent(
+            text.body, origin, "RIGHT", self.file.createIfcPlanarExtent(1000, 1000), f"{y}-{x}"
+        )
+
     def create_variable_representation(self):
         if self.settings["is_wireframe"]:
             return self.create_wireframe_representation()

src/ifcopenshell-python/ifcopenshell/util/element.py

@@ -108,24 +108,6 @@ def replace_attribute(element, old, new):
                     element[i] = new_attribute
 
 
-def is_representation_of_context(representation, context, subcontext=None, target_view=None):
-    if target_view is not None:
-        return (
-            representation.ContextOfItems.is_a("IfcGeometricRepresentationSubContext")
-            and representation.ContextOfItems.TargetView == target_view
-            and representation.ContextOfItems.ContextIdentifier == subcontext
-            and representation.ContextOfItems.ContextType == context
-        )
-    elif subcontext is not None:
-        return (
-            representation.ContextOfItems.is_a("IfcGeometricRepresentationSubContext")
-            and representation.ContextOfItems.ContextIdentifier == subcontext
-            and representation.ContextOfItems.ContextType == context
-        )
-    elif representation.ContextOfItems.ContextType == context:
-        return True
-
-
 def remove_deep(ifc_file, element):
     # @todo maybe some sort of try-finally mechanism.
     ifc_file.batch()
@@ -159,14 +141,3 @@ def copy_deep(ifc_file, element):
                 attribute[j] = copy_deep(ifc_file, item)
         new[i] = attribute
     return new
-
-
-def get_representation(element, context, subcontext=None, target_view=None):
-    if element.is_a("IfcProduct") and element.Representation:
-        for r in element.Representation.Representations:
-            if is_representation_of_context(r, context, subcontext, target_view):
-                return r
-    elif element.is_a("IfcTypeProduct") and element.RepresentationMaps:
-        for r in element.RepresentationMaps:
-            if is_representation_of_context(r.MappedRepresentation, context, subcontext, target_view):
-                return r.MappedRepresentation

src/ifcopenshell-python/ifcopenshell/util/representation.py

@@ -0,0 +1,42 @@
+def get_context(ifc_file, context, subcontext=None, target_view=None):
+    if subcontext or target_view:
+        elements = ifc_file.by_type("IfcGeometricRepresentationSubContext")
+    else:
+        elements = ifc_file.by_type("IfcGeometricRepresentationContext", include_subtypes=False)
+    for element in elements:
+        if context and element.ContextType != context:
+            continue
+        if subcontext and getattr(element, "ContextIdentifier") != subcontext:
+            continue
+        if target_view and getattr(element, "TargetView") != target_view:
+            continue
+        return element
+
+
+def is_representation_of_context(representation, context, subcontext=None, target_view=None):
+    if target_view is not None:
+        return (
+            representation.ContextOfItems.is_a("IfcGeometricRepresentationSubContext")
+            and representation.ContextOfItems.TargetView == target_view
+            and representation.ContextOfItems.ContextIdentifier == subcontext
+            and representation.ContextOfItems.ContextType == context
+        )
+    elif subcontext is not None:
+        return (
+            representation.ContextOfItems.is_a("IfcGeometricRepresentationSubContext")
+            and representation.ContextOfItems.ContextIdentifier == subcontext
+            and representation.ContextOfItems.ContextType == context
+        )
+    elif representation.ContextOfItems.ContextType == context:
+        return True
+
+
+def get_representation(element, context, subcontext=None, target_view=None):
+    if element.is_a("IfcProduct") and element.Representation:
+        for r in element.Representation.Representations:
+            if is_representation_of_context(r, context, subcontext, target_view):
+                return r
+    elif element.is_a("IfcTypeProduct") and element.RepresentationMaps:
+        for r in element.RepresentationMaps:
+            if is_representation_of_context(r.MappedRepresentation, context, subcontext, target_view):
+                return r.MappedRepresentation