Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-22 09:08:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

#1348 special case profiledefwithvoids, needs more work

Browse Source
This commit is contained in:
Thomas Krijnen
2021-02-27 10:58:22 +01:00
parent 3eacd809b0
commit f257aef8f4
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/IfcGeomShapes.cpp
+10 -3
View File
@@ -253,14 +253,21 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcExtrudedAreaSolidTapered* l, T
result = sewer.SewedShape(); result = sewer.SewedShape();
// @todo ugly hack
// The reason for this distinction is that at this point of the loop we're not sure anymore
// whether this was constructed from an inner or outer bound. So rather than iterating over
// wires of `face1` and `face2` we should iterate over the faces and then properly check with
// BRepTools::OuterBound().
// Currently this distinction happens based on profile type which is not robust and probably
// not complete.
if (shell.IsNull()) { if (shell.IsNull()) {
shell = result; shell = result;
} else if (l->SweptArea()->declaration().is(IfcSchema::IfcCircleHollowProfileDef::Class()) || } else if (l->SweptArea()->declaration().is(IfcSchema::IfcCircleHollowProfileDef::Class()) ||
l->SweptArea()->declaration().is(IfcSchema::IfcRectangleHollowProfileDef::Class())) l->SweptArea()->declaration().is(IfcSchema::IfcRectangleHollowProfileDef::Class()) ||
l->SweptArea()->declaration().is(IfcSchema::IfcArbitraryProfileDefWithVoids::Class()))
{ {
/// @todo a bit of of a hack, should be sufficient
shell = BRepAlgoAPI_Cut(shell, result).Shape(); shell = BRepAlgoAPI_Cut(shell, result).Shape();
break;
} else { } else {
if (compound.IsNull()) { if (compound.IsNull()) {
compound_builder.MakeCompound(compound); compound_builder.MakeCompound(compound);