Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-12 10:33:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Selector: negate list comparisons as an aggregate #8129

Browse Source 
compare() recursed into list values passing the negated comparison through,
so != meant "at least one item differs" and both = and != matched the same
elements on any multi-valued property (e.g. an enumerated property with two
values selected). Strip the negation for the per-item comparison and negate
the aggregate instead, so != means "no item equals" and stays the complement
of =. The same applies to !*=.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 209c44db83)
This commit is contained in:
Petru Conduraru
2026-07-09 13:24:46 +03:00
committed by Dion Moult
parent ad6f9bbbf6
commit f761156dea
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/test/util/test_selector.py
+6
View File
@@ -279,6 +279,12 @@ class TestFilterElements(test.bootstrap.IFC4):
pset = ifcopenshell.api.pset.add_pset(self.file, product=element, name="Pset_WallCommon")
ifcopenshell.api.pset.edit_pset(self.file, pset=pset, properties={"Status": ["New"]})
assert subject.filter_elements(self.file, "IfcWall, Pset_WallCommon.Status=New") == {element}
# On multi-valued properties, != means "no value equals" and stays the
# complement of = (#8129).
ifcopenshell.api.pset.edit_pset(self.file, pset=pset, properties={"Status": ["New", "Demolish"]})
assert subject.filter_elements(self.file, "IfcWall, Pset_WallCommon.Status=New") == {element}
assert subject.filter_elements(self.file, "IfcWall, Pset_WallCommon.Status!=New") == {element2}
assert subject.filter_elements(self.file, "IfcWall, Pset_WallCommon.Status!=Temporary") == {element, element2}
def test_selecting_by_property_with_comparisons(self):
element = ifcopenshell.api.root.create_entity(self.file, ifc_class="IfcWall")