Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-14 03:14:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

ifcviewer: auto-guess FederatedFalseOrigin on first model added

Browse Source 
When the user adds a model into a fresh, untitled federation that still
has the default (0,0,0, no rotation) FederatedFalseOrigin, derive an
origin from the first instance's placement_transformation (lifted
through CoordinateOperation when enabled) and the helmert grid-north
baked into ModelGeoref::coordinate_operation_meters.  Multi-file batches
naturally settle: whichever load finishes first anchors the federation,
the rest see a non-default origin and skip.  Saved .ifcfeds keep their
authoritative origin.

Adds Placement.{h,cpp} (port of util/placement.py — a2p,
get_axis2placement, get_local_placement) so Geolocation no longer needs
its own anonymous getAxis2Placement, and xaxis2angleDeg in Geolocation
mirroring util/geolocation.xaxis2angle.

SceneLoader captures the first instance's placement_transformation from
either the sidecar's InstanceCpu[0] or the streamer's first
InstanceChunk, so the guess works on both load paths without re-reading
the IFC.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Dion Moult
2026-05-03 10:04:39 +10:00
parent 8ffdb8f0b9
commit f7add7f412
10 changed files with 333 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcviewer-full/MainWindow.cpp
+26 -2
View File
@@ -594,6 +594,30 @@ void MainWindow::applyFederatedFalseOriginToViewport() {
viewport_->setFederatedFalseOrigin(M);
}
void MainWindow::maybeGuessFederatedFalseOrigin(uint32_t mid) {
// Only auto-guess for untitled federations. A saved .ifcfed carries its
// authoritative origin (even if that happens to be the default), so we
// never silently overwrite it when the user re-adds a model.
if (!federation_->filePath().isEmpty()) return;
// Skip once the origin is non-default — either the user edited it, a
// previous batch already guessed, or a load-from-file populated it.
// For a multi-file batch this means whichever model finishes first
// anchors the federation; the rest see a non-default origin and skip.
const FederatedFalseOrigin& cur = federation_->federatedFalseOrigin();
const FederatedFalseOrigin def;
if (cur.xyz != def.xyz || cur.rz_deg != def.rz_deg) return;
const Eigen::Matrix4d* placement = loader_->firstPlacement(mid);
const ModelGeoref* gr = loader_->modelGeoref(mid);
if (placement == nullptr || gr == nullptr) return;
const FederatedFalseOrigin guess = guessFederatedFalseOrigin(
*placement, *gr, federation_->config(),
AppSettings::instance().applyCoordinateOperation());
federation_->setFederatedFalseOrigin(guess);
}
void MainWindow::onLoadedFromSidecar(uint32_t mid, qint64 elapsed_ms) {
progress_bar_->setVisible(false);
status_label_->setText(QString("%1 elements across %2 model(s) — loaded from cache in %3")
@@ -606,6 +630,7 @@ void MainWindow::onLoadedFromSidecar(uint32_t mid, qint64 elapsed_ms) {
// ModelTransformation immediately rather than waiting for the
// (possibly never-arriving) data-source load.
applyCoordinateOperationToViewport(mid);
maybeGuessFederatedFalseOrigin(mid);
}
void MainWindow::onStreamedElementsReady(uint32_t /*mid*/, std::vector<ElementInfo> elements) {
@@ -714,9 +739,8 @@ void MainWindow::onLoadedFromStream(uint32_t mid, qint64 elapsed_ms) {
.arg(loader_->modelCount())
.arg(formatElapsed(elapsed_ms)));
// Stream path: the IFC is owned by the streamer, so georef is
// computable now. (Sidecar-hit models defer to onDataSourceReady.)
applyCoordinateOperationToViewport(mid);
maybeGuessFederatedFalseOrigin(mid);
writeSidecarForModel(mid);
}