From f91e9a3119c8348de2bc41ff12f2666c98ec79cb Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Sat, 18 Feb 2023 21:10:27 +1100 Subject: [PATCH] Fix BCF bug where viewpoints were not created with a .bcfv suffix which is not compliant. --- src/bcf/src/bcf/v2/topic.py | 4 ++-- src/bcf/src/bcf/v3/topic.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bcf/src/bcf/v2/topic.py b/src/bcf/src/bcf/v2/topic.py index 8587522ec0..94c36068b3 100644 --- a/src/bcf/src/bcf/v2/topic.py +++ b/src/bcf/src/bcf/v2/topic.py @@ -241,8 +241,8 @@ class TopicHandler: self.add_visinfo_handler(vi_handler) def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None: - self.viewpoints[new_viewpoint.guid] = new_viewpoint - self.markup.viewpoints.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid, guid=new_viewpoint.guid)) + self.viewpoints[new_viewpoint.guid + ".bcfv"] = new_viewpoint + self.markup.viewpoints.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid + ".bcfv", guid=new_viewpoint.guid)) def __eq__(self, other: object) -> bool | NoReturn: return ( diff --git a/src/bcf/src/bcf/v3/topic.py b/src/bcf/src/bcf/v3/topic.py index bc77fd448e..188a4b3f81 100644 --- a/src/bcf/src/bcf/v3/topic.py +++ b/src/bcf/src/bcf/v3/topic.py @@ -187,10 +187,10 @@ class TopicHandler: self.add_visinfo_handler(vi_handler) def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None: - self.viewpoints[new_viewpoint.guid] = new_viewpoint + self.viewpoints[new_viewpoint.guid + ".bcfv"] = new_viewpoint if self.topic.viewpoints is None: self.topic.viewpoints = mdl.TopicViewpoints() - self.topic.viewpoints.view_point.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid, guid=new_viewpoint.guid)) + self.topic.viewpoints.view_point.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid + ".bcfv", guid=new_viewpoint.guid)) def __eq__(self, other: object) -> bool | NoReturn: return (