82f73c29ea
style.assign_representation_styles: fix crash on IfcPresentationStyleAssignment #7883
...
When replacing a style on an item whose previous IfcStyledItem wraps its styles
in the deprecated IfcPresentationStyleAssignment, and the assignment is not
being reused (use_style_assignment is False, e.g. an IFC4 file authored by
AVEVA E3D), the else branch called remove_same_type_styles(style_assignment)
with style_assignment still None, raising
AttributeError: 'NoneType' object has no attribute 'Styles'. Operate on style_,
the assignment found in the current iteration, instead of the accumulator.
Verified red-green with a minimal IFC4 file using IfcPresentationStyleAssignment.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com >
2026-07-24 16:46:29 +10:00
b35f99e63f
ty: detect unresolved references
2026-07-18 22:39:33 +05:00
26280d24fe
Add ty to check for missing symbols and other simple errors
2026-03-20 15:36:14 +05:00
eba798c544
typing
2026-03-13 20:26:22 +05:00
dfc91e6639
ifcopenshell-python - clean up unused imports
2026-01-16 17:16:24 +05:00
13be6ccd45
Sort imports
2025-12-19 18:53:14 +05:00
f3b63aae76
Use should_use_presentation_style_assignment
2025-07-06 18:39:21 +02:00
8534333092
Update doc comment
2025-07-06 18:34:50 +02:00
8cfd6b1754
Unify doc-strings (remove type/rtype)
...
As this information is already provided in type hints and we don't need to maintain it in two places.
2025-06-30 18:55:14 +05:00
02d359d0e6
Fix Ruff UP035 (also deprecated annotation symbols)
2025-06-09 18:03:19 +05:00
0e8810c1f5
typing
2025-03-14 18:19:02 +05:00
db52e70121
Fix possibility of adding new invalid surface styles
...
1) Add default values for new IfcSurfaceStyleLighting so they won't appear invalid.
2) Temporarily disable starting surface style with a texture style since it requires additional texture UI to be exposed or some default texture to be assigned to keep it valid.
2025-02-28 18:31:14 +05:00
5eb9cb2ee4
len(get_inverse) -> get_total_inverses
2025-02-24 18:52:35 +05:00
e6d3396630
typing
2025-02-21 18:45:11 +05:00
cf1647a451
Fix bugs in 17642ca4e9
2025-02-21 17:31:33 +05:00
331f491d50
typing
2025-02-20 19:12:24 +05:00
174f909137
Fix #6192
2025-02-20 17:01:12 +05:00
17642ca4e9
typing
2025-02-18 18:50:34 +05:00
8436817408
Update incorrect docs and raise suspicion about how shape aspect styles are assigned
2025-02-01 15:55:34 +11:00
6090c1c669
typing
2024-12-09 18:30:04 +05:00
acd93ead4d
Fix crash during test_remove_fill_area_with_fill_area_style_hatching
2024-11-11 16:31:14 +05:00
bba862e3ae
Fix #5544 . Assign / add of objects with styles are now supported.
2024-10-09 18:27:36 +11:00
f63a7d420e
style.remove_style to handle IfcFillAreaStyles
2024-10-01 15:38:46 +05:00
19f1c87437
style.remove_style to handle IfcFillAreaStyleHatching
2024-10-01 15:38:46 +05:00
b7c390585b
ios - fix error removing other IfcPresentationStyles
...
besides IfcSurfaceStyle
2024-10-01 15:38:45 +05:00
9953ce1b39
typing
2024-09-20 22:03:19 +05:00
b911b68aec
typing
2024-09-13 18:50:54 +05:00
e87faa167c
typing
...
also small optimization in MaterialCreator.create to address ifc a couple times less
2024-09-09 17:28:24 +05:00
27b9709b78
style.assign_representation_styles to support topology reprensentations #4038
2024-09-09 17:28:23 +05:00
3860884db3
bonsai other ifcopenshell packages #5178
2024-08-14 16:49:34 +05:00
07060fc769
Replace all ifcopenshell.api.run with ifcopenshell.api static functions.
2024-06-28 12:36:31 +10:00
a594a6cfe2
typing
2024-06-21 17:49:02 +05:00
4a5d1eba0b
specify exported api methods in __all__
...
It's py.types requirement, similar to 6e2edbf
2024-06-03 17:44:05 +05:00
bb8e84e5ec
typing
2024-05-15 17:18:33 +05:00
1e630ede08
ifc2x3 tests
2024-05-10 19:18:09 +05:00
c50d1ea2fe
typing
2024-05-10 19:18:08 +05:00
10d30b0de7
Document api modules and require explicit imports of API submodules
2024-05-08 17:00:35 +10:00
d11ec67129
Generate functions for all API usecases for better static code features. See #2693 .
2024-05-06 14:43:43 +10:00
a213ab6760
Fix docstrings to reference datatype as it would be used for users
2024-05-06 08:39:48 +10:00
59cc9c0a16
material.assign_material - support batching #4474
2024-04-12 17:41:37 +05:00
1160d20d33
small fixes
2024-03-11 11:39:18 +05:00
a971860094
style.assign_representation_styles to replace previously assigned styles
...
as probably in the most cases user would want 1 style per 1 representation item
After this it's finally possible in BBIM to assign styles to representation items through the materials: https://imgur.com/a/cgiJ1KV
2024-02-22 13:41:34 +05:00
2e45d4a57e
unassign_material_style to handle constituents
2024-02-21 15:15:03 +05:00
0d8c86a0f6
api.unassign_representation_styles
2024-02-21 15:14:28 +05:00
7f0df72fec
assigning material styles to reuse existing styled item + tests
2024-02-21 15:14:28 +05:00
863a8248af
assign_representation_styles to reuse existing styled item + tests
2024-02-21 12:36:06 +05:00
bdc991856c
style.assign_material_style small optimization
2024-02-21 11:32:48 +05:00
96a8c1e8ae
style.assign_material_style to assign style to related shape aspects
2024-02-19 18:08:18 +05:00
f8af28f12a
style.edit_surface_style to support editing IfcSurfaceStyleLighting
...
It was failing because api method wasn't supporting IfcColourRgb attributes edit in general but only for IfcSurfaceStyleShading.SurfaceColour
2023-12-13 16:53:58 +05:00
c4080626df
style.add_surface_texture to work without blender material provided
2023-12-13 14:07:48 +05:00
Petru Conduraru