Thomas Krijnen
47312e1fbb
Reduce log noise on materials without styles #7947
2026-05-08 15:00:30 +02:00
Thomas Krijnen
5b0511379b
IfcAxis1Placement.Axis is optional #7728
2026-02-27 11:06:45 +01:00
Thomas Krijnen
bd5a1b5bda
Account 2x3/4 differences in Shading/Rendering::Transparency()
2025-10-30 18:35:20 +01:00
Thomas Krijnen
eb1c81514b
Check for attribute nil #7276 #7291
2025-10-28 10:51:31 +01:00
Thomas Krijnen
9e2c7e653f
Commit suggestion in #7276
2025-10-22 14:37:10 +02:00
Thomas Krijnen
200c0bf773
Commit suggestion in #7276
2025-10-22 13:23:34 +02:00
Thomas Krijnen
b712f30ad3
Don't assign material as style when it doesn't have any styles #6314
2025-04-07 21:25:33 +02:00
Thomas Krijnen
e9460a2c9a
Actually Eigen::Quaterniond arg order is *w* xyz
2025-03-28 12:10:03 +01:00
Thomas Krijnen
26b55216ca
Normalize model-rotation quaternion
2025-03-19 11:40:54 +01:00
Thomas Krijnen
a687a90039
Break out multiple tasks per representation when rep is directly reused #5978
2025-01-15 10:24:52 +01:00
Thomas Krijnen
d271fd1779
Fail faster on representation map not suitable for reuse #5672
2024-12-17 20:58:10 +01:00
Thomas Krijnen
bd7c19a861
Defensiveness #5683
2024-12-17 20:57:01 +01:00
Thomas Krijnen
ea48996f0d
Double check for relationship subtype when processing openings on aggregate parent #5639
2024-10-26 14:53:36 +02:00
Andrej730
6b55e5e6ee
Fix find_openings for ifc2x3 #5639
2024-10-25 17:43:41 +05:00
Andrej730
e8eb3972a1
Support styles without shading styles after 189bcd5
...
Noticed that after 189bcd5 some representations were missing styles - the ones that are using IfcSurfaceStyle with just IfcExternallyDefinedSurfaceStyle.
Ping @aothms just in case
2024-10-21 16:45:50 +05:00
Thomas Krijnen
189bcd5ad6
Maintain identity and cache styles based on surface-style-shading not styled-item #5486
2024-10-10 16:48:30 +02:00
csritter
a8157e7dd6
Merge branch 'v0.8.0' into v0.8.0
2024-09-25 11:20:47 -03:00
Thomas Krijnen
a51ed6e6b3
Fixes for using hybrid kernel on non-products #5443
2024-09-23 16:18:00 +02:00
Thomas Krijnen
d879bf9f89
Reintroduce --model-offset/-rotation MODEL_OFFSET/_ROTATION setting #5231
2024-09-13 11:38:24 +02:00
Cristian Ritter
a450c24739
Merge branch 'v0.8.0' of https://github.com/csritter/IfcOpenShell into v0.8.0
2024-08-26 15:34:55 -03:00
Cristian Ritter
56d19039e3
always apply in diffuse color, if doens't have surface color
...
Signed-off-by: Cristian Ritter <cristian_ritter@hotmail.com >
2024-08-26 15:34:50 -03:00
csritter
2b8124071a
Merge branch 'v0.8.0' into v0.8.0
2024-08-26 10:26:10 -03:00
Cristian Ritter
9fceec35cc
add diffuse on surface, if has no surface color
...
Signed-off-by: Cristian Ritter <cristian_ritter@hotmail.com >
2024-08-26 10:17:50 -03:00
Thomas Krijnen
d80bcd1a94
Unify variant storage ( #5118 )
2024-08-23 20:29:07 +02:00
Cristian Ritter
876f059459
remove surface white if doesn't have surface colour
...
Signed-off-by: Cristian Ritter <cristian_ritter@hotmail.com >
2024-08-15 14:18:13 -03:00
Cristian Ritter
b5a61753a5
Adding --surface-color in conversion settings to force the use of surface color instead of diffuse color. Issue #5075
2024-08-15 13:56:31 -03:00
Richard Brice
b22ecba179
Implements mutually exclusive access to mapping cache with a mutex
2024-08-01 07:15:22 -07:00
Andrej730
a1d8fbdbe9
Fix missing materials from sets #5093 #4832
...
Regression in ifcopenshell 0.8 - missing materials and styles from IfcMaterialProfileSets, IfcMaterialProfileSetUsages, IfcMaterialLayerSet.
2024-07-27 15:38:22 +05:00
Thomas Krijnen
91f4427bb5
Start from project instead of unit assignment #5074
2024-07-25 10:23:12 +02:00
Thomas Krijnen
b988df9e1f
Address old merge issue regarding style lookup #5069
2024-07-24 03:07:17 +02:00
Thomas Krijnen
dda010b130
Wire up ___localplacement settings #5031
2024-07-23 10:15:52 +02:00
Andrej730
355cca3679
Improve styles handling (partially support non-shading styles/fix bugs)
...
1) Previously create_shape (was failing with "RuntimeError: Unexpected topology") or iterator (was hanging indefinetely trying initialize with a IfcSlab from #4898 ) were breaking if element had a material that had IfcSurfaceStyle with just IfcExternallyDefinedSurfaceStyle and no IfcSurfaceStyleShading.
Now get_surface_style is returning IfcSurfaceStyle as first element of the pair even if there was no IfcSurfaceStyleShading - so it can be used to create a `taxonomy::style::ptr` with it to indicate that geometry is still referring to some style.
2) Added logs for unsupported presentation styles (non-IfcSurfaceStyles) to both `mapping::map_impl(const IfcSchema::IfcStyledItem* inst)` and `mapping::map_impl(const IfcSchema::IfcMaterial* material)`. Also `map_impl` will not break now if it will meet IfcCurveStyle.
2024-07-09 20:13:59 +05:00
Thomas Krijnen
675e1982ee
Move macro logic into template function; mark failures as intended #4915
2024-07-01 20:34:51 +02:00
Thomas Krijnen
278524ee3e
Uninitialized use of context
2024-06-24 21:52:31 +02:00
Thomas Krijnen
a9912f351f
Don't dereference empty unit assignment list
2024-06-24 21:52:08 +02:00
Andrej730
1e092c140f
add ifc2x3 support for 301cdf650
2024-06-21 17:50:22 +05:00
Andrej730
301cdf6504
Fix creating representation with inherited materials
...
It should be considered as inherited material can also have a style.
Though occurrence's material is still prioritized.
2024-06-21 14:52:37 +05:00
Thomas Krijnen
2a5e42e359
Don't log 'no op defined' for failed conversions
2024-06-11 20:09:37 +02:00
Thomas Krijnen
dae7d86dad
Fix style lookup in accordance with v0.7 #4844
2024-06-11 20:09:37 +02:00
Thomas Krijnen
c2efcda7bb
Don't use cached items in multi-threaded mode for now until we have proper immutability
2024-06-11 11:20:40 +02:00
Thomas Krijnen
7af9944c27
find_openings() on representation as a hint for hybrid kernel
2024-04-29 21:29:34 +02:00
Thomas Krijnen
ae2600afb9
Set style name
2024-04-29 20:51:17 +02:00
Thomas Krijnen
29fd32be75
Fixes after settings rework
2024-04-18 21:15:40 +02:00
Thomas Krijnen
64454a001f
Apply handling of openings on IfcFeatureElementSubtraction generically #3889
2024-04-16 11:03:26 +02:00
Chetan
86c93ac1e7
If an IFC file has an IFCRELASSOCIATESMATERIAL but did not supply an IFCMATERIAL, IfcConvert will crash. This commit prevents the crash, catches the exception and prints an error on the terminal
2024-04-15 11:16:59 +02:00
Thomas Krijnen
b52c5ab082
Don't emit empty results for representation and allow implicit items to
...
pass when using --plan
2023-11-21 14:41:31 +01:00
Thomas Krijnen
65e874c67f
Drastic settings refactoring
2023-11-15 10:32:33 +01:00
Richard Brice
7b0e2c52ac
Manually merged in aothms revisions for gradient curves and implicit_item taxonomy
2023-10-02 16:30:39 -07:00
Thomas Krijnen
5bead4b219
#2805 Apply changes to v0.8 geometry mapping as well
2023-09-14 11:33:23 +02:00
Thomas Krijnen
65a5646bf0
Major update: taxonomy shared pointers, collection type safety, work towards hashing
2023-07-27 16:42:06 +08:00