Per review, do not hard-code the uniqueness rules. express_parser already
captures each entity's UNIQUE clauses (nodes.entity_definition.unique), but
they were dropped at codegen. Emit them, via the same pipeline that already
produces the WHERE rules, into the generated express/rules/<SCHEMA>.py
modules, and have validate read them from there so the data tracks the
EXPRESS schema.
- express/nodes.py: capture the full attribute list per UNIQUE clause
(label, (attrs...)); previously only the first attribute was kept, which
silently dropped compound clauses such as IfcApplication.UR2
(ApplicationFullName, Version).
- express/rule_compiler.py: collect_uniqueness_rules / format_uniqueness_rules
emit a uniqueness_rules dict into every generated rules module.
- express/rules/{IFC2X3,IFC4,IFC4X1,IFC4X2}.py: carry the generated dict.
- validate.py: get_uniqueness_rules reads it statically (ast, cached, no
heavy import; graceful {} if absent) and validate_uniqueness_rules applies
it generically. IfcRoot.UR1 and IfcApplication keep their dedicated paths
to avoid double-reporting.
Verified: get_uniqueness_rules('IFC4') returns IfcApplication /
IfcPropertyEnumeration / IfcRoot from the rules module; a duplicate
IfcPropertyEnumeration name (IFC4) and IFC2X3 UR clauses are flagged, valid
files clean, no double-reporting. All test/test_validate.py fixtures (40)
pass; black and ruff clean.
Refs #4499. IFC4X3 variants gain the dict automatically on the next full
rules regeneration; validate no-ops gracefully until then.
Generated with the assistance of an AI coding tool.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* temp reasonable state, missing rule_head contents
* better state, with init() and rule_id, but some missing parameters
* performance; embed root in dict; fix lookup
* Add ast_utils
* Fixes related to listnode and typo
* First steps with code gen
* Finalize first steps towards working code generation
* Backwards compat
* Rule execution, error formatting, test cases
* Where rule: support indexing, more expressions, test plane angle measure
* positive length measure test cases
* Venture into entity rules, test actor role
* Fixed for not unary op and address test cases
* Test group qualifier and air terminal type
* typeof() implementation and test annotation curve occ
* Flexible handling of expression, type set intersection, IfcAnnotationSurface test cases
* Functions, derived attrs, fix branch order, allow to terminate branches, apply -1 to index
* Implement express query(), test cases for 2x3 bspline curve
* Function args, if-else, repeat, entity instance construction, cshape test cases
* Multiple function call arguments and other small but influential changes. IfcDotProject() almost working except for variable case
* Make lowercase and fix assignment to qualified lhs
* Entity instance schema without file, aggregate assignment workaround, range fix, lowercase instance locals, extruded area direction test cases
* Enumeration item handling, query() robustness, arbitrary profile test cases
* Empty aggregate_initializer, xor and instance equality, nested expression fix in IfcCrossProduct, axis2-3d test cases
* Numeric stable sort with indices greater then 10, get ast node parent, redeclared derived support, nested expression robustness, define entity functions, case statements, xor, mod, bool literals, nvl, unknown, conversion based unit test cases
* Safeguard for schema name case norm, case norm query variable_id
* free instance comparison, supertype serialization fix, include inherited attributes in locals, proper elif-else in case stmt, loindex, shape rep test cases
* Union operator on set, retain general_aggr_types in parse tree, test cases for property set
* Escape stmt, rule locals and statements
* Return calculated values for redeclared derived attributes
* fix for rules without stmt, add derived and inverse attributes to locals, filter unused locals, wrap exists() arg with lambda to catch indexerror, support repeated aggr init element, typeof() none check, enum namespace uppercase
* Regen 2x3 rules
* Rule test filter only on basename
* Update fixtures for compliance with full body of rules
* Add rule support to ifcopenshell.validate
* Implement usedin() function, test cases for IfcWallSC MLS
* blength
* Run code generation on all schemas
* Try to eliminate runtime pyparsing dep
* Try to eliminate runtime pyparsing dep
Petru Conduraru