Commit Graph

22784 Commits

Author SHA1 Message Date
Andrej730 20d56efdfc win: remove outdated msys2 scripts
They were very outdated and if we'll need msys2 support, we'll be able to introduce it later in our Python scripts.
2026-09-09 16:43:04 +05:00
Andrej730 7cfb146717 vs-cfg: remove redundant where cl check
`START` is set to `0` for "amd64" / "x64" and `1` in all other cases, effectively just skipping `GENERATORS[0]` in case when "amd64" or "x64" is present.
Which is now useless, since `GENERATORS[0]` doesn't exist anymore.
2026-09-09 16:43:04 +05:00
Andrej730 dc9218e9eb vs-cfg: remove unused Win64 code
We don't have any generators with `Win64` suffix (they were removed 36f51e1), so this code was unreachable.
2026-09-09 16:43:04 +05:00
Andrej730 d399581f11 vs-cfg: remove VS_HOST / VS_TOOLSET_HOST
They were added awhile ago in 67666ed for overcoming some win32 issues, which is not around anymore.
And now `VS_HOST` is never set (and therefore `VS_TOOLSET_HOST` is always empty too) and likely to be never used.
2026-09-09 16:43:04 +05:00
Andrej730 21691616fd vs-cfg: move examples next to debug prints 2026-09-09 16:43:04 +05:00
Andrej730 995f98d5fe vs-cfg: add support for missing toolsets in gen shortcut 2026-09-09 16:43:04 +05:00
Andrej730 550150b339 ci-lint: check whitespace issues
Was testing this script for a couple weeks on Linux, found no issues, seems reliable. Also tested it on Windows today.
2026-09-09 16:43:04 +05:00
Andrej730 dc69c19aa7 ifcopenshell-python: move mathutils related tests to Bonsai
Previously tests never ran since workflow targets 3.11 and running tests is gated by Python 3.13.
bonsai-0.9.0-alpha2609040826
2026-09-04 13:26:05 +05:00
Andrej730 253448c32a geometry_creation.rst: shape_build doesnt' depend on mathutils 2026-09-04 13:26:05 +05:00
Andrej730 9bd9af6211 svgfill: fix gcc -Wcomment
Example:
```
src/svgfill/src/progress.h:2:1: warning: ‘/*’ within comment [-Wcomment]
```
2026-09-03 19:55:54 +05:00
Andrej730 a4503f72af ci: use python available from PATH to retrieve include
One less place to update on version change.
2026-09-03 19:55:54 +05:00
Andrej730 aea6badbaa build-bonsaiviewer-autodesk: install missing libs
CI was failing:
```
  The system library `dbus-1` required by crate `libdbus-sys` was not found.
  The file `dbus-1.pc` needs to be installed and the PKG_CONFIG_PATH environment variable must contain its parent directory.
  The PKG_CONFIG_PATH environment variable is not set.
```
2026-09-03 19:55:54 +05:00
Andrej730 e5f7981729 bonsaiviewer-autodesk: fix clippy 2026-09-03 19:55:54 +05:00
Andrej730 a8b59ee296 ci-lint: reuse astral-sh/setup-uv 2026-09-03 19:55:54 +05:00
Andrej730 462a05e662 black_to_github_annotations: inline dependency 2026-09-03 19:55:54 +05:00
Andrej730 2b7970509e Move ci script to .github/scripts 2026-09-03 19:55:54 +05:00
Andrej730 75da4e950d Remove check_repo_ci_jobs.py
Seems to be orphaned since 9fe40c3
2026-09-03 19:55:54 +05:00
Andrej730 5114ae26ea ci-ifcwrap-standalone: deduplicate wrapper building code 2026-09-03 19:55:54 +05:00
Andrej730 2613fb53ba ci: add paths missing from paths filter 2026-09-03 19:55:54 +05:00
Andrej730 f6ca05e32c ifcgeom: remove commented out map_impl(IfcCompositeCurve)
It was specific to occt, now it's superseded by `map_impl` residing in the same file, but it's kernel-agnostic.
2026-09-03 19:55:54 +05:00
Andrej730 5529bc0ffe Remove occt kernel citation
It was an artifact from `src/ifcgeom_schema_agnostic/CITATION.cff`, we already have `src/ifcgeom/CITATION.cff` to cover this.
2026-09-03 19:55:54 +05:00
Andrej730 a8e94d7097 Remove ifcgeom_schema_agnostic references
Removed long time ago during refactor ccde605
2026-09-03 19:55:54 +05:00
Andrej730 63c34d0f9d Remove ifcjni references (c2abc3f) 2026-09-03 19:55:54 +05:00
Andrej730 70bb008ff8 ci: dedup paths filters 2026-09-03 19:55:54 +05:00
Andrej730 403a23a976 ci: reuse push paths filter for pull_request 2026-09-03 19:55:54 +05:00
Andrej730 57a9e1e304 cmake: export document_serializer_rdb
There was an error building a standalone ifcwrap when previously built IfcOpenShell had rocksdb - `_ifcopenshell_wrapper.cpython-314-x86_64-linux-gnu.so: undefined symbol: _ZTV17RocksDbSerializer`.

`IFOPSH_WITH_ROCKSDB` propagated to the build, requiring rocksdb symbols, but `WITH_ROCKSDB` wasn't set and `document_serializer_rdb` target wasn't provided.
2026-09-03 19:55:54 +05:00
Andrej730 2db248e017 cmake/ifcwrap: skip insallation of .pyc files 2026-09-03 19:55:54 +05:00
Andrej730 d4fa8e4f62 cmake/ifcwrap: skip versioned .so files during source copy
E.g. files like `libTKBinTObj.so.7.8.1`. Same reasoning as for skipping other binaries.
2026-09-03 19:55:54 +05:00
Andrej730 b2a90920e1 cmake: build svgfill without BUILD_IFCPYTHON
Otherwise it will never be able to reach standalone ifcwrap build as in this case ifcopenshell is built first as a dependency without `BUILD_IFCPYTHON`.
2026-09-03 19:55:54 +05:00
Andrej730 ee12e36dcd cmake/ifcwrap: remove requirement for svgfill target
Since it's a plugin now and not linked directly.
`LIBSVGFILL` variable was set, but never used.
2026-09-03 19:55:54 +05:00
Andrej730 87fd9209e1 ci-ifcwrap-standalone: ccache swig build 2026-09-03 19:55:54 +05:00
Andrej730 e18d927b40 ci-ifcwrap-standalone: use ccache 2026-09-02 20:41:26 +05:00
Andrej730 5aaf2107a5 test_package: xfail for current binary
It's missing pyodide build and we already allowed it, test will start failing on the next binary bump.
bonsai-0.9.0-alpha2609021508
2026-09-02 20:08:33 +05:00
Andrej730 7826e7d177 ci: colorful output for pytest 2026-09-02 20:08:33 +05:00
Andrej730 6b176e8b4a ci: use github annotations to show in summary what test suite has failed
Otherwise they can get burried in logs.
2026-09-02 20:08:33 +05:00
Andrej730 b6550c5aba bonsai/make: unpin brickschema
It was pinned in 84dcee6b3 due to the back-then-latest package being too big and alpha version was fixing it (also see https://github.com/IfcOpenShell/IfcOpenShell/issues/4368 )
`brickschema` is now 0.7.9, so the pin is no longer needed
2026-09-02 20:08:33 +05:00
Andrej730 c23972d440 test_brick: fix warnings from sqlalchemy
When fixing warnings, noticed that was working a bit inproperly - `bnode` always end up being an empty list (because there's no `brick, A, REF.IFCReference` triple), so then passing empty list to `triples` resulted in selecting all nodes isntead of just the expected `bnode` (that's the behaviour `sqlachemy` was sending the warnings about - when empty lists unexpectedly selected everything).
2026-09-02 20:08:33 +05:00
Andrej730 4eb093eefa typing: modernize Generator annotations
`None, None` assumed by default.
Though this was introduced in Python 3.13, before 3.13 it only breaks if we'd do `typing.Generator[T]` (which is deprecated) -`collections.abc.Generator[T]` works fine, it seems it never had an arity check.
2026-09-02 20:08:33 +05:00
Andrej730 261d2ce9a2 stub: get_attribute_category to consider derived attrs 2026-09-02 20:08:33 +05:00
Andrej730 1fa5eebf0c sql, stream: raise for accessing derived attributes
Raising `AttributeError` is definitely wasn't correct here, since it
might push the code to assume it's a wrong entity type. Returning some stub value like `None` also could suggest incorrect derived attribute
value, leading to unexpected behaviour. So adding an error, so it would
propagate and code would need to be adjusted not to rely on derived
attributes, if it actually interacts with sql/stream.

`test_unit` was asserting that derived attr will return `None`, though
it was actually raising `AttributeError`.
2026-09-02 20:08:33 +05:00
Andrej730 2b0ebcee32 sql: remove debug prints 2026-09-02 20:08:33 +05:00
Andrej730 6b62723aae typing 2026-09-02 20:08:33 +05:00
Andrej730 66126d21bc test_package: remove the requirement for intel Mac build 2026-09-02 20:08:33 +05:00
Andrej730 c2f39a70a3 gitignore: ignore all shared objects in ifcopenshell folder
Using symlinks just for main libs/pluigins doesn't seems to resolve `$ORIGIN` for some reason - e.g. occt libraries appears to be missing. So symlinking everything, including the dependencies seems to be the way to create a dev environment.
2026-09-02 20:08:33 +05:00
Andrej730 1f627690b6 bonsai dev-requirements: add brickschema, rdflib 2026-09-02 20:08:33 +05:00
Thomas Krijnen d11440af65 Address failing tests
* import-mode=import-lib to prevent temp rename

* Skip some failing tests

* Update stub

* Fix decorator
bonsai-0.9.0-alpha2609021356
2026-09-02 15:56:15 +02:00
Thomas Krijnen 99f1051d18 Run black 2026-09-02 13:48:31 +02:00
Petru Conduraru df3d07e952 fix(ifctester): accept tuple results when chaining facet filters
Facet.filter() implementations broad-phase query with
ifc_file.by_type(), then check isinstance(elements, list) to decide
whether a previous facet already narrowed the candidate set. In
v0.9.0, file.by_type() returns a tuple instead of a list, so that
check silently failed and every facet after the first re-scanned the
whole model instead of the already-narrowed (possibly empty) set.
This let a prohibited Entity+Attribute applicability match instances
of the wrong class, e.g. an IfcSlab satisfying an "IFCWALL" Entity
facet's chain. Accept tuples too, matching how by_type() results are
actually returned now.
bonsai-0.9.0-alpha2609021135
2026-09-02 13:36:14 +02:00
Petru Conduraru e7370dff9f fix(sql): recognise derived attributes in sqlite_entity.__getattr__
get_attribute_category() returns 3 for a derived attribute, but
sqlite_entity.__getattr__() only branched on FORWARD (1) and INVERSE
(2), so any derived attribute (e.g. IfcSIUnit.Dimensions) fell
through to the final AttributeError instead of returning None, which
is what SQLite-linked files are documented to do since derived
attributes are not computed for them. Mirrors the DERIVED handling
already present in entity_instance.py's __getattr__.
2026-09-02 13:35:51 +02:00
Petru Conduraru 040bebedfb fix(ifcdiff): resolve elements by GlobalId via by_guid, not by_id
diff() looked up common elements with self.old.by_id(global_id) /
self.new.by_id(global_id), passing a GlobalId string into a method
that expects a STEP integer id. On v0.8.0 file.by_id() was a Python
wrapper that transparently dispatched strings to by_guid(), so the
bug was silent. v0.9.0's file class binds by_id directly to the
C++ instance_by_id(int), so it now raises
TypeError: in method 'file_by_id', argument 2 of type 'int'.
2026-09-02 13:35:16 +02:00