13 Commits

Author	SHA1	Message	Date
Andrej730	b5d24334fd	Fixed bug with wrong position of support in wall mounted railing ... The problem was that that support's disk was not rotated according to the railing path.	2024-04-15 09:52:38 +02:00
Andrej730	1dcf74eb60	WALL_MOUNTED_HANDRAIL type for Railing modifier ... Added WALL_MOUNTED_HANDRAIL type for railing modifier. It's still a bit work in progress - still need to add support for different railing termination types. Here's the short demonstration - https://user-images.githubusercontent.com/9417531/234582621-6c6f948b-9cdc-4be6-b380-17ddbf5803bf.mp4	2024-04-15 09:52:37 +02:00
Andrej730	d2124e1c8b	Fixed bugs with furniture library toilets and basins #2976 ... Bug was introduced in cf6acd5 when `shape_builder.get_rectangle_coords` started returning coords in counter-clockwise order instead of clockwise.	2024-04-15 09:37:49 +02:00
Andrej730	5d4ecb7177	Sliding doors - moved annotation arrow to Annotation/PLAN_VIEW #2919	2024-04-15 09:25:49 +02:00
Andrej730	be75ef2596	Fixed ifc validation errors for furniture library #2925 ... Fixed bunch of validation errors with furniture library: - IfcSpaceType PredefinedType wasn't optional `<attribute PredefinedType: <enumeration IfcSpaceTypeEnum: (EXTERNAL, GFA, INTERNAL, NOTDEFINED, PARKING, SPACE, USERDEFINED)>> Not optional` - some object had 0.0 depth extrusion ``` Rule IfcPositiveLengthMeasure_WR1: (self > 0.) Violated by: (0.0 > 0.0) ``` - some orphan representations violating: ``` Rule IfcShapeModel_WR11: ((sizeof(self.OfProductRepresentation) == 1) ^ (sizeof(self.RepresentationMap) == 1) ^ (sizeof(ofshapeaspect) == 1)) Violated by: ((0 == 1 ^ 0 == 1) ^ 0 == 1) + where 0 = sizeof(()) + where () = #9091=IfcShapeRepresentation(#15,'Body','SweptSolid',(#9090)).OfProductRepresentation + and 0 = sizeof(()) + where () = #9091=IfcShapeRepresentation(#15,'Body','SweptSolid',(#9090)).RepresentationMap + and 0 = sizeof(()) ```	2024-04-15 09:25:48 +02:00
Andrej730	ec882a1a7d	Fixed validation error for ELEVATION_VIEW curves #2925 ... Error occured because ShapeBuilder was assigning "Curve2D" representation type for elevation view curves when the correct type is "Curve3D". It use to occur for both doors and windows created with ifc modifier. ``` Validation error text: 2023-04-03:18:21:28,879 ERROR [rule_executor.py:154] On instance: #135=IfcShapeRepresentation(#21,'Profile','Curve2D',(#134)) Rule IfcShapeRepresentation_CorrectItemsForType: (IfcShapeRepresentationTypes(self.RepresentationType,self.Items)) Violated by: False + where False = IfcShapeRepresentationTypes('Curve2D', (#134=IfcIndexedPolyCurve(#133,(IfcLineIndex((1,2)),IfcLineIndex((2,3)),IfcLineIndex((3,4)),IfcLineIndex((4,1))),$),)) + where 'Curve2D' = #135=IfcShapeRepresentation(#21,'Profile','Curve2D',(#134)).RepresentationType + and (#134=IfcIndexedPolyCurve(#133,(IfcLineIndex((1,2)),IfcLineIndex((2,3)),IfcLineIndex((3,4)),IfcLineIndex((4,1))),$),) = #135=IfcShapeRepresentation(#21,'Profile','Curve2D',(#134)).Items ```	2024-04-15 09:25:48 +02:00
Andrej730	3095521e36	Fixed some validation errors for doors and windows #2925 ... Fixed the ones caused by using 3d curves as inner/outer curves in profiles.	2024-04-15 09:25:48 +02:00
Andrej730	0d0691a012	Door modifier - double doors type support	2023-02-11 16:09:13 +05:00
Dion Moult	50d71d5ea1	Black code and make profile representation optional for windows.	2023-02-09 20:13:14 +11:00
Andrej730	9f0ad9be3c	Black formatting window modifier	2023-01-25 11:13:41 +05:00
Andrej730	cf6acd5dd6	ShapeBuilder - added 3d rectangles and polylines support	2023-01-25 11:10:20 +05:00
Andrej730	d0cf5f9d0c	Fixed ShapeBuilder bug for mirroring IfcExtrudedAreaSolid ... Also fixed typo in shape_builder_examples	2023-01-25 11:10:19 +05:00
Andrej730	1888048d4d	Moved ShapeBuilder to separate module #2679 ... Moved ShapeBuilder to separate module - now `mathutils` will be only required if you're actually using ShapeBuilder (related to #2679)	2023-01-08 19:47:18 +05:00