Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-12 02:23:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,847 Commits 400 Branches 3,017 Tags
f88835b87b2098ca5b1d755ef944abdf7f640211
Commit Graph

11 Commits

Author SHA1 Message Date
Andrej730 f88835b87b Corrected L shapes in window lining after e89a9cd #3271 
From this - https://i.imgur.com/hQuCcR3.png
To this - https://i.imgur.com/qZ2Lyfo.png

It's a bit hacky since we still use really small offsets to keep "The outer curve shall enclose all inner curves." rule for IfcArbitraryProfileDefWithVoids valid.
 2023-06-28 15:56:38 +05:00
Andrej730 e89a9cd01c adjust window offset on transoms/mullions for symmetry #3271 
Before -  https://i.imgur.com/DbEzJ9H.png
After - https://i.imgur.com/0CERh86.png

Added it for modifier preview and ifc 2d and 3d repr but still need to work some things in 3d representation (L shape lining is not always detected correctly).
 2023-06-27 19:30:49 +05:00
Andrej730 afeeaeb984 Fixed some validation errors for doors and windows #2925 
Fixed the ones caused by using 3d curves as inner/outer curves in profiles.
 2023-04-03 19:53:42 +05:00
Andrej730 6a87b68c3b Window Modifier - added 2d representation 
+ fixed lining offset for door 2d representation
 2023-02-14 16:54:43 +05:00
Andrej730 e1456533f2 Doors - clean up + black format 2023-02-06 18:53:48 +05:00
Andrej730 b2bdbdd8c3 Door modifier - basic setup 
Also:
- refactored window modifier code - part of it is now reused building a door and can be used by other module in the future
- fixed bug with window lining intersecting frame when lining_depth < panel_depth
- simplified the way lining is built in ifc - previously it was using 4-6 extrusions, now it's 1-2 which is also better for 2D drawings
 2023-02-06 18:44:09 +05:00
Andrej730 978f362073 More consistent default and current units for stair and window modifiers 2023-01-30 12:44:11 +05:00
Andrej730 74477d0051 Window modifier - removed hardcoded mm units 
Related to #2724
 2023-01-26 18:29:58 +05:00
Andrej730 04bdb12e79 Window Modifier - added mullions/transoms, removed relative panel dimensions 2023-01-26 12:30:34 +05:00
Andrej730 9f0ad9be3c Black formatting window modifier 2023-01-25 11:13:41 +05:00
Andrej730 a6271d0936 IFC Window modifier 
Added IFC Window in object modifiers tab (works similar way to Ifc Stair)
 2023-01-25 11:13:41 +05:00