mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-10 01:41:57 +00:00
Petru Conduraru
57c3d4b176
The validate_space_boundaries, validate_storey_containment and validate_wall_connectivity translation units only ever built when the default-off WITH_RELATIONSHIP_VALIDATION CMake option was enabled, and their fix_* entry points were never reachable from the IfcConvert command line. The code has drifted from the current geometry kernel API (Iterator now takes a std::unique_ptr<AbstractKernel>, create_nef_polyhedron takes a CGAL polyhedron rather than a CgalShape), so any build with the option enabled fails to compile, as reported in the issue for MSVC and reproducible with clang on macOS. Per maintainer direction on the issue, remove the feature instead of patching it: the plan is to redo this kind of validation in Python on top of ConversionResult(Shape). This deletes the validation sources, the option, and the conditional source glob, leaving IfcConvert built from IfcConvert.cpp alone, which was already the default. Fixes #7444. Generated with the assistance of an AI coding tool.