mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-16 18:44:47 +00:00
Gorgious56
12f9e377c8
Pre-existing architectural smell on v0.8.0: core/root.py.copy_class
called a module-level _has_material_styles helper that did
ifcopenshell.util.element.get_materials() directly, bypassing the
Prophecy mock seam that every other branch in copy_class flowed
through. Symptom: test/core/test_root.py::TestCopyClass::
test_AAAAAAAAAAAA passed mock strings into copy_class, the helper
called .is_a() on the string, AttributeError.
Move the check to tool.Root.has_material_styles (paired with
assign_body_styles — they're called in sequence as "is there a
material style? if not, assign body style"). core/root.py now
calls root.has_material_styles(new) like every other dependency,
fixing the test failure and dropping the ifcopenshell.util.element
import that was the only consumer of the ifcopenshell import at
module load in core/root.py.
* core/tool.py: add abstract has_material_styles to Root interface.
* tool/root.py: add concrete classmethod near assign_body_styles.
* core/root.py: replace _has_material_styles helper call site with
root.has_material_styles; drop the local helper and its import.
* test/core/test_root.py: add the new mock expectation
root.has_material_styles("element").will_return(False) before the
existing assign_body_styles expectation.
Generated with the assistance of an AI coding tool.
216 lines
11 KiB
Python
216 lines
11 KiB
Python
# Bonsai - OpenBIM Blender Add-on
|
|
# Copyright (C) 2021 Dion Moult <dion@thinkmoult.com>
|
|
#
|
|
# This file is part of Bonsai.
|
|
#
|
|
# Bonsai is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Bonsai is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Bonsai. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
import bonsai.core.root as subject
|
|
import test.core.test_geometry
|
|
from test.core.bootstrap import collector, geometry, ifc, root
|
|
|
|
|
|
class TestCopyClass:
|
|
def test_doing_nothing_if_not_an_ifc_element(self, ifc, collector, root):
|
|
ifc.get_entity("obj").should_be_called().will_return(None)
|
|
subject.copy_class(ifc, collector, geometry, root, obj="obj")
|
|
|
|
def test_copy_with_new_geometry_derived_from_the_type(self, ifc, collector, root):
|
|
ifc.get_entity("obj").should_be_called().will_return("original_element")
|
|
root.is_element_a("original_element", "IfcRelSpaceBoundary").should_be_called().will_return(False)
|
|
root.get_object_representation("obj").should_be_called().will_return("representation")
|
|
ifc.run("root.copy_class", product="original_element").should_be_called().will_return("element")
|
|
ifc.link("element", "obj").should_be_called()
|
|
root.get_element_type("element").should_be_called().will_return("type")
|
|
root.does_type_have_representations("type").should_be_called().will_return(True)
|
|
ifc.run("type.map_type_representations", related_object="element", relating_type="type").should_be_called()
|
|
ifc.get_object("type").should_be_called().will_return("type_obj")
|
|
root.link_object_data("type_obj", "obj").should_be_called()
|
|
collector.assign("obj").should_be_called()
|
|
subject.copy_class(ifc, collector, geometry, root, obj="obj")
|
|
|
|
# def test_copy_with_new_geometry_copied_from_the_old(self, ifc, collector, geometry, root):
|
|
def test_AAAAAAAAAAAA(self, ifc, collector, geometry, root):
|
|
ifc.get_entity("obj").should_be_called().will_return("original_element")
|
|
root.is_element_a("original_element", "IfcRelSpaceBoundary").should_be_called().will_return(False)
|
|
root.get_object_representation("obj").should_be_called().will_return("representation")
|
|
ifc.run("root.copy_class", product="original_element").should_be_called().will_return("element")
|
|
ifc.link("element", "obj").should_be_called()
|
|
root.get_element_type("element").should_be_called().will_return("type")
|
|
root.does_type_have_representations("type").should_be_called().will_return(False)
|
|
root.copy_representation("original_element", "element").should_be_called().will_return("copied_entities")
|
|
geometry.copy_data_links("data", "copied_entities").should_be_called()
|
|
geometry.change_object_data("obj", "data", is_global=True).should_be_called()
|
|
geometry.duplicate_object_data("obj").should_be_called().will_return("data")
|
|
ifc.get_entity("data").should_be_called().will_return("new_representation")
|
|
geometry.get_representation_name("new_representation").should_be_called().will_return("name")
|
|
geometry.rename_object("data", "name").should_be_called()
|
|
root.has_material_styles("element").should_be_called().will_return(False)
|
|
root.assign_body_styles("element", "obj").should_be_called()
|
|
collector.assign("obj").should_be_called()
|
|
subject.copy_class(ifc, collector, geometry, root, obj="obj")
|
|
|
|
def test_copy_with_no_new_geometry(self, ifc, collector, geometry, root):
|
|
ifc.get_entity("obj").should_be_called().will_return("original_element")
|
|
root.is_element_a("original_element", "IfcRelSpaceBoundary").should_be_called().will_return(False)
|
|
root.get_object_representation("obj").should_be_called().will_return(None)
|
|
ifc.run("root.copy_class", product="original_element").should_be_called().will_return("element")
|
|
ifc.link("element", "obj").should_be_called()
|
|
root.get_element_type("element").should_be_called().will_return("type")
|
|
root.does_type_have_representations("type").should_be_called().will_return(False)
|
|
collector.assign("obj").should_be_called()
|
|
subject.copy_class(ifc, collector, geometry, root, obj="obj")
|
|
|
|
def test_copying_boundaries_are_dealt_with_specially(self, ifc, collector, geometry, root):
|
|
ifc.get_entity("obj").should_be_called().will_return("original_element")
|
|
root.is_element_a("original_element", "IfcRelSpaceBoundary").should_be_called().will_return(True)
|
|
ifc.run("boundary.copy_boundary", boundary="original_element").should_be_called().will_return("element")
|
|
ifc.link("element", "obj").should_be_called()
|
|
assert subject.copy_class(ifc, collector, geometry, root, obj="obj") == "element"
|
|
|
|
|
|
class TestAssignClass:
|
|
def test_do_nothing_if_already_assigned(self, ifc, collector, root):
|
|
ifc.get_entity("obj").should_be_called().will_return("entity")
|
|
subject.assign_class(
|
|
ifc,
|
|
collector,
|
|
root,
|
|
obj="obj",
|
|
ifc_class="ifc_class",
|
|
predefined_type="predefined_type",
|
|
should_add_representation=True,
|
|
context="context",
|
|
ifc_representation_class="ifc_representation_class",
|
|
)
|
|
|
|
def test_assign_a_class_with_geometry_and_autodetected_spatial_container_spatial_element(
|
|
self, ifc, collector, root
|
|
):
|
|
ifc.get_entity("obj").should_be_called().will_return(None)
|
|
root.get_object_name("obj").should_be_called().will_return("name")
|
|
ifc.run(
|
|
"root.create_entity", ifc_class="ifc_class", predefined_type="predefined_type", name="name"
|
|
).should_be_called().will_return("element")
|
|
root.set_object_name("obj", "element").should_be_called()
|
|
ifc.link("element", "obj").should_be_called()
|
|
root.run_geometry_add_representation(
|
|
obj="obj", context="context", ifc_representation_class="ifc_representation_class", profile_set_usage=None
|
|
).should_be_called()
|
|
|
|
root.is_drawing_annotation("element").should_be_called().will_return(False)
|
|
root.get_default_container().should_be_called().will_return("default_container")
|
|
root.is_spatial_element("element").should_be_called().will_return(True)
|
|
ifc.run("aggregate.assign_object", products=["element"], relating_object="default_container").should_be_called()
|
|
|
|
collector.assign("obj").should_be_called()
|
|
subject.assign_class(
|
|
ifc,
|
|
collector,
|
|
root,
|
|
obj="obj",
|
|
ifc_class="ifc_class",
|
|
predefined_type="predefined_type",
|
|
should_add_representation=True,
|
|
context="context",
|
|
ifc_representation_class="ifc_representation_class",
|
|
)
|
|
|
|
def test_assign_a_class_with_geometry_and_autodetected_spatial_container_non_spatial_containable(
|
|
self, ifc, collector, root
|
|
):
|
|
ifc.get_entity("obj").should_be_called().will_return(None)
|
|
root.get_object_name("obj").should_be_called().will_return("name")
|
|
ifc.run(
|
|
"root.create_entity", ifc_class="ifc_class", predefined_type="predefined_type", name="name"
|
|
).should_be_called().will_return("element")
|
|
root.set_object_name("obj", "element").should_be_called()
|
|
ifc.link("element", "obj").should_be_called()
|
|
root.run_geometry_add_representation(
|
|
obj="obj", context="context", ifc_representation_class="ifc_representation_class", profile_set_usage=None
|
|
).should_be_called()
|
|
|
|
root.is_drawing_annotation("element").should_be_called().will_return(False)
|
|
root.get_default_container().should_be_called().will_return("default_container")
|
|
root.is_spatial_element("element").should_be_called().will_return(False)
|
|
root.is_containable("element").should_be_called().will_return(True)
|
|
root.is_in_aggregate_mode("element").should_be_called().will_return(False)
|
|
root.is_in_nest_mode("element").should_be_called().will_return(False)
|
|
ifc.run(
|
|
"spatial.assign_container", products=["element"], relating_structure="default_container"
|
|
).should_be_called()
|
|
|
|
collector.assign("obj").should_be_called()
|
|
subject.assign_class(
|
|
ifc,
|
|
collector,
|
|
root,
|
|
obj="obj",
|
|
ifc_class="ifc_class",
|
|
predefined_type="predefined_type",
|
|
should_add_representation=True,
|
|
context="context",
|
|
ifc_representation_class="ifc_representation_class",
|
|
)
|
|
|
|
def test_assign_a_class_to_drawing_annotation_without_assigning_container(self, ifc, collector, root):
|
|
ifc.get_entity("obj").should_be_called().will_return(None)
|
|
root.get_object_name("obj").should_be_called().will_return("name")
|
|
ifc.run(
|
|
"root.create_entity", ifc_class="ifc_class", predefined_type="predefined_type", name="name"
|
|
).should_be_called().will_return("element")
|
|
root.set_object_name("obj", "element").should_be_called()
|
|
ifc.link("element", "obj").should_be_called()
|
|
root.run_geometry_add_representation(
|
|
obj="obj", context="context", ifc_representation_class="ifc_representation_class", profile_set_usage=None
|
|
).should_be_called()
|
|
|
|
root.is_drawing_annotation("element").should_be_called().will_return(True)
|
|
|
|
collector.assign("obj").should_be_called()
|
|
subject.assign_class(
|
|
ifc,
|
|
collector,
|
|
root,
|
|
obj="obj",
|
|
ifc_class="ifc_class",
|
|
predefined_type="predefined_type",
|
|
should_add_representation=True,
|
|
context="context",
|
|
ifc_representation_class="ifc_representation_class",
|
|
)
|
|
|
|
def test_not_adding_a_representation_if_requested_no_default_container(self, ifc, collector, root):
|
|
ifc.get_entity("obj").should_be_called().will_return(None)
|
|
root.get_object_name("obj").should_be_called().will_return("name")
|
|
ifc.run(
|
|
"root.create_entity", ifc_class="ifc_class", predefined_type="predefined_type", name="name"
|
|
).should_be_called().will_return("element")
|
|
root.set_object_name("obj", "element").should_be_called()
|
|
ifc.link("element", "obj").should_be_called()
|
|
root.is_drawing_annotation("element").should_be_called().will_return(False)
|
|
root.get_default_container().should_be_called().will_return(None)
|
|
collector.assign("obj").should_be_called()
|
|
subject.assign_class(
|
|
ifc,
|
|
collector,
|
|
root,
|
|
obj="obj",
|
|
ifc_class="ifc_class",
|
|
predefined_type="predefined_type",
|
|
should_add_representation=False,
|
|
context="context",
|
|
ifc_representation_class="ifc_representation_class",
|
|
)
|