mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-09-21 14:23:53 +00:00
Richard Brice
4374c81981
* Honour IfcAxis2PlacementLinear Axis/RefDirection in the loft builder make_loft() (src/ifcgeom/infra_sweep_helper.cpp), shared by IfcSectionedSolidHorizontal and IfcSectionedSurface, mishandled a cross section's IfcAxis2PlacementLinear in two ways: 1. A placement carrying Axis but no RefDirection was placed with a fixed [e_y | e_z | e_x] world-axis permutation that ignored the directrix. On any directrix not running along +X (e.g. a north-south road pavement, or anywhere along a curve) the profile came out mis-oriented or collapsed to a sliver. 2. When two adjacent CrossSectionPositions used direction vectors inconsistently (a raked RefDirection at one, a plain Axis at the other) make_loft() logged GEO 42, dropped the rotation for the whole segment and squared every cap -- and in one configuration left the sweep frame flipped, so OpenCASCADE failed to build the solid at all. Now a small profile_basis() helper builds every cross section's frame the same way: profile Y = Axis, profile normal = RefDirection, and -- when RefDirection is absent -- profile normal = the directrix tangent, so the section stays perpendicular to the path (buildingSMART IFC4.x-IF #147). When the two bracketing placements ask for the same orientation the sweep frame carries it, built against the curve. When they disagree the sweep frame stays on the shared Axis (continuous with the neighbouring consistent segments, so nothing flips) and each end's own authored orientation is folded into its profile points via a change of basis, so each end cap still lands exactly as authored while the body in between keeps following the directrix. The all-equal and no-direction-vector paths are unchanged. The two mappings now also carry the raw RefDirection through on cross_section, alongside the existing rotation matrix. Adds C++ tests (a raked end logs no GEO 42; a directrix that does not run along +X still lofts a full-size solid) and Python tests (uniform prism raked at one end and square at the other; a north-south directrix keeps its width; OffsetLateral/OffsetVertical are scaled by the model length unit). * Renames profile_rotations to profile_axis for consistency with profile_ref_directions