mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-13 10:57:49 +00:00
Petru Conduraru
71c18a9ad1
When vertices are not welded (the default IfcConvert path when normals are requested), IfcGeom::Representation::Triangulation stores one position and one normal per triangle corner, so both arrays repeat the same values many times. The OBJ and COLLADA formats support indexing positions, normals and texture coordinates independently, but the serializers were reusing a single combined index for all of them, inflating output size without needing to. Positions and normals are now deduplicated by exact value within each serializer and referenced through their own index streams (UV indices are left untouched, since a UV depends on both position and normal together). Verified against a real IFC model (test/input/IfcReinforcingBar.ifc): DAE output drops from 48.4MB to 20.6MB (-57.5%) and OBJ output from 51.3MB to 23.6MB (-54.0%), with the decoded position/normal value for every triangle corner checked byte-identical to the unpatched output. Addresses #46. Generated with the assistance of an AI coding tool.
52 lines
2.6 KiB
C++
52 lines
2.6 KiB
C++
/********************************************************************************
|
|
* *
|
|
* This file is part of IfcOpenShell. *
|
|
* *
|
|
* IfcOpenShell is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the Lesser GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3.0 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* IfcOpenShell is distributed in the hope that it will be useful, *
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
|
|
* Lesser GNU General Public License for more details. *
|
|
* *
|
|
* You should have received a copy of the Lesser GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
* *
|
|
********************************************************************************/
|
|
|
|
#ifndef WAVEFRONTOBJSERIALIZER_H
|
|
#define WAVEFRONTOBJSERIALIZER_H
|
|
|
|
#include <set>
|
|
#include <string>
|
|
#include <fstream>
|
|
|
|
#include "../serializers/serializers_api.h"
|
|
#include "../ifcgeom/GeometrySerializer.h"
|
|
|
|
// http://people.sc.fsu.edu/~jburkardt/txt/obj_format.txt
|
|
class SERIALIZERS_API WaveFrontOBJSerializer : public WriteOnlyGeometrySerializer {
|
|
private:
|
|
stream_or_filename obj_stream;
|
|
stream_or_filename mtl_stream;
|
|
size_t vcount_total, ncount_total, uvcount_total;
|
|
std::set<std::string> materials;
|
|
public:
|
|
WaveFrontOBJSerializer(const stream_or_filename& obj_filename, const stream_or_filename& mtl_filename, const ifcopenshell::geometry::Settings& geometry_settings, const ifcopenshell::geometry::SerializerSettings& settings, Logger* logger = nullptr);
|
|
virtual ~WaveFrontOBJSerializer() {}
|
|
bool ready();
|
|
void writeHeader();
|
|
void writeMaterial(const ifcopenshell::geometry::taxonomy::style::ptr style);
|
|
void write(const IfcGeom::TriangulationElement* o);
|
|
void write(const IfcGeom::BRepElement* /*o*/) {}
|
|
void finalize() {}
|
|
bool isTesselated() const { return true; }
|
|
void setUnitNameAndMagnitude(const std::string& /*name*/, float /*magnitude*/) {}
|
|
void setFile(IfcParse::IfcFile*) {}
|
|
};
|
|
|
|
#endif
|