mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-06 07:51:47 +00:00
Dion Moult
9d9f4054f6
The Python implementation of the Autodesk Forma connector
(bonsaiviewer_autodesk/) is deprecated. The Rust port that's been
maturing under src/bonsaiviewer-autodesk-rs/ is now the connector
and takes over the original folder name.
## File operations
* `git rm -r src/bonsaiviewer-autodesk` — drop the 18 tracked Python
source/test/packaging files. (~6.5k untracked build artefacts in
venv/build/dist/egg-info are removed too, but those were never in
the index.)
* `mv src/bonsaiviewer-autodesk-rs src/bonsaiviewer-autodesk` —
the Rust impl takes over the canonical folder name.
* `rm -rf src/bonsaiviewer-autodesk-rs-egui` — abandoned egui-based
experiment, never committed.
* `src/bonsaiviewer-autodesk/.gitignore` extended with `/dist` to
keep packaging output out of the index alongside the existing
`/target` rule.
The Rust binary in Cargo.toml already has `name = "bonsaiviewer-
autodesk"` and `connector.json`'s `exec` field already points at that
name — so the connector loader, build_viewer.sh symlink, and
win/build-all-win.py CONNECTOR_DIR all keep working without edits.
## Packaging shape preserved
`packaging/build.py` is rewritten to:
* shell out to `cargo build --release` instead of pyinstaller,
* copy the produced binary + connector.json into the same
`dist/autodesk/` layout the PyInstaller flow produced,
* zip into `dist/autodesk-<os>-<arch>.zip` with the same
naming pattern (CI artifact uploads keep working).
The Rust binary statically links its deps, so unlike PyInstaller
there's no `_internal/` directory — single executable inside
`dist/autodesk/`. Everything downstream (`build_viewer.sh` symlink,
`win/build-all-win.py collect_connector_files`, the zip step in
`build_rocky.yml`) only cares that `dist/autodesk/` exists, so the
on-disk contract is preserved.
Verified locally: `python3 src/bonsaiviewer-autodesk/packaging/build.py`
produces `dist/autodesk/{bonsaiviewer-autodesk, connector.json}`
(3.9 MB stripped ELF) and `dist/autodesk-linux-x86_64.zip` (~1.5 MB
compressed).
## CI updates
* `.github/workflows/build_rocky.yml` and `build_rocky_arm.yml`:
drop the `pip install ".[build]"` step — `packaging/build.py` is
stdlib-only now, the cargo build wrapped inside it does the work.
* `.github/workflows/build_win.yml`: same — drop pip install,
packaging script handles cargo internally.
* `.github/workflows/build-bonsaiviewer-autodesk.yml`: full rewrite
of the dedicated connector test/build workflow. Replaces the
Python {3.11, 3.13} test matrix with `cargo fmt --check`,
`cargo clippy --all-targets -- -D warnings`, and `cargo test
--all-features`. The OS/arch build matrix is unchanged
(linux-x86_64, macos-arm64, macos-x86_64, windows-x86_64) but
installs a Rust toolchain via dtolnay/rust-toolchain@stable and
caches target/ via Swatinem/rust-cache.
`win/build-all-win.py` and `build_viewer.sh` are unchanged — they
only reference the `dist/autodesk/` path, which the new
`packaging/build.py` populates identically.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
94 lines
2.6 KiB
YAML
94 lines
2.6 KiB
YAML
name: Build Bonsai Viewer Autodesk Connector
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
push:
|
|
paths:
|
|
- 'src/bonsaiviewer-autodesk/**'
|
|
- '.github/workflows/build-bonsaiviewer-autodesk.yml'
|
|
pull_request:
|
|
paths:
|
|
- 'src/bonsaiviewer-autodesk/**'
|
|
- '.github/workflows/build-bonsaiviewer-autodesk.yml'
|
|
|
|
jobs:
|
|
test:
|
|
name: cargo-test
|
|
runs-on: ubuntu-latest
|
|
|
|
defaults:
|
|
run:
|
|
working-directory: src/bonsaiviewer-autodesk
|
|
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
|
|
- uses: dtolnay/rust-toolchain@stable
|
|
|
|
# cargo-target reuse across runs. Massive cold-build speedup,
|
|
# cheap on the GitHub Actions cache budget.
|
|
- uses: Swatinem/rust-cache@v2
|
|
with:
|
|
workspaces: src/bonsaiviewer-autodesk
|
|
|
|
- name: cargo fmt --check
|
|
run: cargo fmt --all -- --check
|
|
|
|
- name: cargo clippy
|
|
run: cargo clippy --all-targets --all-features -- -D warnings
|
|
|
|
- name: cargo test
|
|
run: cargo test --all-features
|
|
|
|
build:
|
|
name: ${{ matrix.os_label }}-${{ matrix.arch }}
|
|
needs: test
|
|
runs-on: ${{ matrix.runner }}
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
# Linux: build on the oldest reasonable glibc (Ubuntu 22.04 / glibc
|
|
# 2.35) so the bundle runs on older distributions.
|
|
- os_label: linux
|
|
arch: x86_64
|
|
runner: ubuntu-22.04
|
|
# macOS Apple Silicon.
|
|
- os_label: macos
|
|
arch: arm64
|
|
runner: macos-14
|
|
# macOS Intel. macos-13 is the last Intel runner GitHub provides.
|
|
- os_label: macos
|
|
arch: x86_64
|
|
runner: macos-13
|
|
# Windows x86_64.
|
|
- os_label: windows
|
|
arch: x86_64
|
|
runner: windows-latest
|
|
|
|
defaults:
|
|
run:
|
|
working-directory: src/bonsaiviewer-autodesk
|
|
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
|
|
- uses: dtolnay/rust-toolchain@stable
|
|
|
|
- uses: Swatinem/rust-cache@v2
|
|
with:
|
|
workspaces: src/bonsaiviewer-autodesk
|
|
|
|
# python3 is the runner default on all four hosts; packaging/build.py
|
|
# only uses stdlib (subprocess, shutil, zipfile, pathlib, platform),
|
|
# no pip-installable deps.
|
|
- name: Build connector bundle
|
|
run: python3 packaging/build.py
|
|
|
|
- name: Upload connector zip
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: autodesk-${{ matrix.os_label }}-${{ matrix.arch }}
|
|
path: src/bonsaiviewer-autodesk/dist/autodesk-${{ matrix.os_label }}-${{ matrix.arch }}.zip
|
|
if-no-files-found: error
|