From f89d48a112e06e1e42aeaa1f781c8fa09f7ad8e3 Mon Sep 17 00:00:00 2001
From: Jukka Aho <ahojukka5@gmail.com>
Date: Sun, 9 Nov 2025 17:09:27 +0200
Subject: [PATCH] refactor(deprecated): Remove old getproperty redirection for
 new Element API
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Comment out Base.getproperty(element::Element, :fields) redirection
- Old code redirected element.fields → element.dfields (Dict-based fields)
- New Element has fields::F directly (type-stable NamedTuple or struct)
- No redirection needed with new architecture
- Rationale: New Element{N,NIP,F,B} has fields as direct struct member
---
 src/deprecated_fembase.jl | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/deprecated_fembase.jl b/src/deprecated_fembase.jl
index 15f4a93..42c694e 100644
--- a/src/deprecated_fembase.jl
+++ b/src/deprecated_fembase.jl
@@ -119,14 +119,15 @@ function interpolate(element::AbstractElement, field_name::String, ip, time)
     interpolate(element, Symbol(field_name), ip, time)
 end
 
-# fields is now dfields
-function Base.getproperty(element::Element, sym::Symbol)
-    if sym === :fields  # Use === instead of == (which is overridden by fields.jl)
-        return getfield(element, :dfields)
-    else
-        return getfield(element, sym)
-    end
-end
+# OLD: fields is now dfields - DEPRECATED with new Element{N,NIP,F,B} architecture
+# New Element struct has `fields::F` directly, no need for redirection
+# function Base.getproperty(element::Element, sym::Symbol)
+#     if sym === :fields  # Use === instead of == (which is overridden by fields.jl)
+#         return getfield(element, :dfields)
+#     else
+#         return getfield(element, sym)
+#     end
+# end
 
 # getindex, when someone asks key element.fields["f"] => element.fields[:f]
 function Base.getindex(fieldset::Dict{Symbol,AbstractField}, field_name::String)