Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-09 09:21:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize updating representations adding/removing openings

Browse Source 
No need to update all possible elements from decomposition because openings affect only related objects from IfcRelAggregate. For example, see #5639.
This commit is contained in:
Andrej730
2024-10-30 15:45:49 +05:00
parent 59e0dbae2c
commit 0662b0c5b6
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/bonsai/bim/module/void/operator.py
+3 -4
View File
@@ -115,8 +115,7 @@ class AddOpening(bpy.types.Operator, tool.Ifc.Operator):
bonsai.core.geometry.edit_object_placement(tool.Ifc, tool.Geometry, tool.Surveyor, obj=obj2)
voided_objs = [obj1]
# TODO: should we use get_parts instead?
for subelement in ifcopenshell.util.element.get_decomposition(element1):
for subelement in tool.Aggregate.get_parts_recursively(voided_element):
subobj = tool.Ifc.get_object(subelement)
if subobj:
voided_objs.append(subobj)
@@ -180,8 +179,8 @@ class RemoveOpening(bpy.types.Operator, tool.Ifc.Operator):
ifcopenshell.api.run("void.remove_opening", tool.Ifc.get(), opening=opening)
decomposed_building_elements = set([element])
decomposed_building_elements.update(ifcopenshell.util.element.get_decomposition(element))
decomposed_building_elements = {element}
decomposed_building_elements.update(tool.Aggregate.get_parts_recursively(element))
for building_element in decomposed_building_elements:
building_obj = tool.Ifc.get_object(building_element)