Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-09 21:53:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues with accessing invalid entities in bim.reassign_class #4371

Browse Source 
bim.reassign_class wasn't considering that root.reassign_class will also reassign class for occurrences of the same type and was reaccessing invalid elements
This commit is contained in:
Andrej730
2024-02-28 16:53:08 +05:00
parent 69767a7045
commit 1819b6812e
2 changed files with 85 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blenderbim/test/tool/test_root.py
+28
View File
@@ -169,3 +169,31 @@ class TestSetObjectName(NewFile):
element.Name = "Foobar"
subject.set_object_name(obj, element)
assert obj.name == "IfcWall/Foobar"
class TestReassignClass(NewFile):
def test_run(self):
bpy.context.scene.BIMProjectProperties.template_file = "IFC4 Demo Library.ifc"
bpy.ops.bim.create_project()
ifc_file = tool.Ifc.get()
context = bpy.context
relating_type_id = ifc_file.by_type("IfcSlabType")[0].id()
n_wall_types = len(ifc_file.by_type("IfcWallType"))
n_slab_types = len(ifc_file.by_type("IfcSlabType"))
# create 3 slabs
bpy.ops.bim.add_constr_type_instance(relating_type_id=relating_type_id)
bpy.ops.bim.add_constr_type_instance(relating_type_id=relating_type_id)
bpy.ops.bim.add_constr_type_instance(relating_type_id=relating_type_id)
slabs = [tool.Ifc.get_object(e) for e in ifc_file.by_type("IfcSlab")]
assert len(slabs) == 3
tool.Blender.set_objects_selection(context, slabs[0], (slabs[1],))
context.scene.BIMRootProperties.ifc_product = "IfcElement"
context.scene.BIMRootProperties.ifc_class = "IfcWall"
bpy.ops.bim.reassign_class()
assert len(ifc_file.by_type("IfcWall")) == 3
assert len(ifc_file.by_type("IfcSlab")) == 0
assert len(ifc_file.by_type("IfcWallType")) == n_wall_types + 1
assert len(ifc_file.by_type("IfcSlabType")) == n_slab_types - 1