Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-09 17:31:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve update_existing_properties

Browse Source 
explicit class check
error out on a not supported type
better methods names
This commit is contained in:
Totally a booplicate
2023-06-04 14:43:17 +03:00
parent 0632c9bf1b
commit 182aa3ed01
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py
+7 -5
View File
@@ -203,12 +203,14 @@ class Usecase:
continue
if prop.is_a("IfcPropertyEnumeratedValue"):
self.update_existing_enum(prop)
self.update_existing_prop_enum(prop)
else:
self.update_existing_property(prop)
elif prop.is_a("IfcPropertySingleValue"):
self.update_existing_prop_single_value(prop)
def update_existing_enum(self, prop):
raise NotImplementedError(f"Updating '{prop.is_a()}' properties is not supported yet")
def update_existing_prop_enum(self, prop):
"""
NOTE: Assumes the prop exists
"""
@@ -243,7 +245,7 @@ class Usecase:
prop.Unit = unit
del self.settings["properties"][prop.Name]
def update_existing_property(self, prop):
def update_existing_prop_single_value(self, prop):
"""
NOTE: Assumes the prop exists
"""